Synthetic PoRep #400
Merged
Synthetic PoRep #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we consider developing in a feature branch? |
|
@jennijuju This adds functions that are currently uncalled. |
Do you mean on the lotus side? If so, I would think yes 👍 Or do you mean renaming the existing branch in this repo? |
Which ones? It shouldn't 🤔 |
|
No Lotus code calls the Synthetic PoREP functions yet.
The new functions are called by tests.
…On Wed, May 10, 2023 at 9:57 AM nemo ***@***.***> wrote:
@jennijuju <https://github.com/jennijuju> This adds functions that are
currently uncalled.
Which ones? It shouldn't 🤔
—
Reply to this email directly, view it on GitHub
<#400 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOU4LVJ2AZ3ZMHZD2SHBTLXFOUDXANCNFSM6AAAAAAX3RQCTE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Correct, sorry I misunderstood the question 😅 |
cryptonemo
force-pushed
the
synthetic-porep
branch
from
1dd209f to
8e863d5
Compare
13 tasks
cryptonemo
force-pushed
the
synthetic-porep
branch
from
1210257 to
b52e28c
Compare
cryptonemo
force-pushed
the
synthetic-porep
branch
from
b52e28c to
aa7ba1d
Compare
Stebalien
reviewed
Sep 5, 2023
Those new APIs are about: - decoding a range of an updated empty sector - generating TreeRLast - generating TreeC - running SDR
Add API documentation to the new APIs. Also change one parameter name for more consistency.
fix Cargo lock after broken rebase
update cargo lock feat: updated Cargo.lock Fix Cargo.lock after messy rebase
cryptonemo
force-pushed
the
synthetic-porep
branch
from
d786249 to
21f30a2
Compare
Stebalien
approved these changes
Sep 6, 2023
|
This should be good to go. The next step is to:
|
cryptonemo
added a commit
that referenced
this pull request
Sep 7, 2023
* feat: add various new APIs for Lotus Those new APIs are about: - decoding a range of an updated empty sector - generating TreeRLast - generating TreeC - running SDR * docs: document the new APIs Add API documentation to the new APIs. Also change one parameter name for more consistency. * wip Go bindings for new proving APIs * Add nicer wrapper for GenerateSDR * feat: update proofs to the latest release * cleanup comments in proofs.go * feat: update dependencies to WIP synthetic-porep code * feat: add example of using SynthPoRep in existing test * feat: wire in new APIs * feat: add clear_layer_data API and more robustly use synth-porep in test * feat: go-wrapper for ClearSyntheticProofs * merged synth work * Update deps after (messy) rebase * missing v21 engine mapping * newer cargo lock * feat: point to fvm master after synthporep changes landed * update the fvm & bls-signatures (to match the fvm) --------- Co-authored-by: Volker Mische <volker.mische@gmail.com> Co-authored-by: Łukasz Magiera <magik6k@gmail.com> Co-authored-by: Aayush <arajasek94@gmail.com> Co-authored-by: Andrew Jackson (Ajax) <snadrus@gmail.com> Co-authored-by: Steven Allen <steven@stebalien.com>
cryptonemo
added a commit
that referenced
this pull request
Sep 7, 2023
* feat: add various new APIs for Lotus Those new APIs are about: - decoding a range of an updated empty sector - generating TreeRLast - generating TreeC - running SDR * docs: document the new APIs Add API documentation to the new APIs. Also change one parameter name for more consistency. * wip Go bindings for new proving APIs * Add nicer wrapper for GenerateSDR * feat: update proofs to the latest release * cleanup comments in proofs.go * feat: update dependencies to WIP synthetic-porep code * feat: add example of using SynthPoRep in existing test * feat: wire in new APIs * feat: add clear_layer_data API and more robustly use synth-porep in test * feat: go-wrapper for ClearSyntheticProofs * merged synth work * Update deps after (messy) rebase * missing v21 engine mapping * newer cargo lock * feat: point to fvm master after synthporep changes landed * update the fvm & bls-signatures (to match the fvm) --------- Co-authored-by: Volker Mische <volker.mische@gmail.com> Co-authored-by: Łukasz Magiera <magik6k@gmail.com> Co-authored-by: Aayush <arajasek94@gmail.com> Co-authored-by: Andrew Jackson (Ajax) <snadrus@gmail.com> Co-authored-by: Steven Allen <steven@stebalien.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.