Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config files: what're they for? #45

Closed
phritz opened this issue Feb 1, 2018 · 3 comments
Closed

config files: what're they for? #45

phritz opened this issue Feb 1, 2018 · 3 comments
Assignees

Comments

@phritz
Copy link
Contributor

phritz commented Feb 1, 2018

No description provided.

@phritz
Copy link
Contributor Author

phritz commented Feb 1, 2018

OK, talked to why about this and (briefly) I think we agree that:

  • things that affect server behavior should have artifacts (eg, config files).
  • server config should be concentrated in the fewest different types of mechanisms possible. For example if we have config files don't also smear config across command line flags and and rpc to fetch state from a config server
  • we like config files, favor them over command line flags in general
  • there will be config that doesn't change over the lifetime of the server and config that can (eg, a miner's ask strategy). put these things in separate files.
  • reload reloadable config in response to explicit action (cmd for example)

@whyrusleeping
Copy link
Member

One caveat I'd like to note, I think that command line flags to the daemon process that override certain behaviours is fine. For example, the --offline flag on go-ipfs. Sometimes I want to temporarily run my daemon without networking.

@dignifiedquire
Copy link
Contributor

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants