This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Instrument context failures and Instrument conn latency #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Apr 5, 2023
fetcher.go
Outdated
| if err != nil { | ||
| return | ||
| } | ||
|
|
||
| response_success_end = time.Now() | ||
| { |
lidel
reviewed
Apr 5, 2023
| @@ -71,6 +72,11 @@ func (p *pool) fetchResource(ctx context.Context, from string, resource string, | |||
| if mime == "application/vnd.ipld.raw" { | |||
| resourceType = "block" | |||
| } | |||
| fetchCalledTotalMetric.WithLabelValues(resourceType).Add(1) | |||
| if ctx.Err() != nil { | |||
| fetchRequestContextErrorTotalMetric.WithLabelValues(resourceType, ctx.Err().Error(), "init").Add(1) | |||
There was a problem hiding this comment.
.Error() could return, which will in turn baloon the size of metrics.
Last time I checked we had errors which had the URL / CID of failed request, and that means some errors will be unique .Error() string , exploding metrics space:
http request failed: Get \"https://64.44.166.190/ipfs/bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze/favicon.ico?format=car&depth=0\": context canceled
Maybe log some higher level error type instead? (or a flag to indicate context cancelled or not)
There was a problem hiding this comment.
@lidel Thanks for catching this ! In my mind, the context cancelled error could only be Cancelled or Dead line exceeded ! But I see now.
lidel
added a commit
to ipfs-inactive/bifrost-gateway
that referenced
this pull request
Apr 5, 2023
Includes: filecoin-saturn/caboose#77 + fix for filecoin-saturn/caboose#75 filecoin-saturn/caboose#79 filecoin-saturn/caboose#80 filecoin-saturn/caboose#81 Breaking change: replaced fetch_size with fetch_size_block and fetch_size_car, each with different buckets Diff: filecoin-saturn/caboose@5b42e94...e4b1e88
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.