This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Ensure deadline errors are legit #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Apr 5, 2023
|
@willscott Agreed. I think the whole metrics collection code is going to need a refactor(it's getting messy) but resisting the temptation to do so right now while we are focused on bigger fish. |
lidel
added a commit
to ipfs-inactive/bifrost-gateway
that referenced
this pull request
Apr 5, 2023
Includes: filecoin-saturn/caboose#77 + fix for filecoin-saturn/caboose#75 filecoin-saturn/caboose#79 filecoin-saturn/caboose#80 filecoin-saturn/caboose#81 Breaking change: replaced fetch_size with fetch_size_block and fetch_size_car, each with different buckets Diff: filecoin-saturn/caboose@5b42e94...e4b1e88
|
do we see a count of errors from this fetchIncorrectDeadlineErrorTotalMetric? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.