Add a test for truncate when length is NaN

[seanprashad]

Let's consider adding a test for when fs.truncate's length parameter is NaN (ie. Not a number like stringInputForTruncateExplodes).

The tests live within filer/tests/spec/fs.truncate.spec.js and could possibly slide right under the test when length is negative!

Node.js docs

[seanprashad]

I'll see this one through to finish - keep your 👀 open for a PR!

[seanprashad]

Update: Very interesting - there is no error when a string is passed in for the length, meaning that there's a default somewhere. Currently looking for Found it!

Test Output:

---

The implementation can be found starting at:

filer/src/filesystem/implementation.js

Line 1229 in e3a1187

function truncate_file(context, path, length, callback) {

Update 2: It looks like the length is only checked if it's length is less than 0, let's add a check to see if it's a valid number before we check if it's less than 0 using Number.IsInteger():

filer/src/filesystem/implementation.js

Lines 1280 to 1284 in e3a1187

	if(length < 0) {
	callback(new Errors.EINVAL('length cannot be negative'));
	} else {
	find_node(context, path, read_file_data);
	}