Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate stat and stats tests #738

Closed
humphd opened this issue Feb 7, 2019 · 2 comments
Closed

Consolidate stat and stats tests #738

humphd opened this issue Feb 7, 2019 · 2 comments
Labels
good first bug

Comments

@humphd
Copy link
Contributor

humphd commented Feb 7, 2019

For some reason we have both https://github.com/filerjs/filer/blob/master/tests/spec/fs.stats.spec.js and https://github.com/filerjs/filer/blob/master/tests/spec/fs.stat.spec.js. We should probably just have https://github.com/filerjs/filer/blob/master/tests/spec/fs.stat.spec.js, since there is no stats method.

Let's move the stats tests into stat, and make sure we aren't duplicating any tests.
@oleksii-polovyi
Copy link
Contributor

Hi @humphd, I would like to work on this issue.

@humphd
Copy link
Contributor Author

humphd commented Feb 18, 2019

OK @ApolllonDev, it's yours.

@humphd humphd closed this as completed in 2a4fa0f Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humphd @oleksii-polovyi