Fix blurry thumbnails for some items in grid view #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ADeltaX <adeltaxsystem@gmail.com> Co-authored-by: Thomas <Thomas.Klemenc@gmail.com> Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Co-authored-by: PhonerApp <63700223+PhonerApp@users.noreply.github.com>
* Dispose of StorageItemThumbnails and only use Cached or Embedded Icons * Add Acrylic to Sidebar * Introduce "Bandage Solution" for Item Loading
ghost
added
the
yaira2
approved these changes
May 15, 2020
yaira2
added
ready to merge
Merged
lukeblevins
added a commit
that referenced
this pull request
May 19, 2020
* Fix blurry thumbnails for some items in grid view (#790) * Switch ThumbnailMode to SingleItem for better thumbnails (#791) * Fixed crash when using keyboard shortcuts the home page (#802) * Optimized home page identifying (#804) * Defer adding drives to UI until MainView is activated (#806) * Update Package.appxmanifest Co-authored-by: Luke Blevins <lukeblevins15@gmail.com> Co-authored-by: Vladyslav <tsvetkov_vlad@ukr.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After carefully observing the loading of some items' extended properties (i.e. thumbnails), I noticed that some were being loaded from GenericFileBrowser.cs despite the frame being navigated to the PhotoAlbumView. This PR properly registers/unregisters the event that layout mode views can subscribe to from the ViewModel. Thus, thumbnails are loaded at the correct size always.