Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image bound expands by itself when cropping #71

Closed
marano opened this issue Nov 29, 2017 · 3 comments
Closed

Image bound expands by itself when cropping #71

marano opened this issue Nov 29, 2017 · 3 comments
Labels

Comments

@marano
Copy link

marano commented Nov 29, 2017

(I originally posted this bug to filestack-react at filestack/filestack-react#36)

Versions

filestack-react 1.3.8
filestack-js 0.9.7

How to reproduce it

1 - Open picker
2 - Select photo
3 - Reduce both sides of the photo crop area
4 - Click at one corner of the crop area and expand it to match the photo limit

What happens

The opposite side bounds expand a little bit each time. But the faster the movement the more it expands.

Expected behaviour

Only the side I am dragging should have its bounds resized

Video

bug

@velveteer
Copy link
Contributor

@marano Thanks for reporting. Can you try upgrading to the latest filestack-js (currently 0.9.12) and confirm if this behavior persists?

Can you also provide browser information for this issue?

@marano
Copy link
Author

marano commented Nov 29, 2017

@velveteer I can confirm the issue persists on 0.9.12. It is reproducible on Chrome, Safari and Firefox on macOS High Sierra, didn't try other systems.

@velveteer
Copy link
Contributor

@marano Thanks. I was able to reproduce on 0.9.12 when providing an aspect ratio to the crop settings. I believe this is a bug with cropperjs: fengyuanchen/cropperjs#222, which was only partially addressed, because I am seeing this bug when resizing with the top-left and top-right handles.

I will look into resolving this in cropperjs if possible, but I cannot make any guarantees on when I will have time to make a PR for them. For now we will track this as a bug.

@velveteer velveteer added the bug label Nov 29, 2017
@marano marano changed the title [BUG] Image bound expands by itself when cropping Image bound expands by itself when cropping Nov 30, 2017
@pcholuj pcholuj closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants