Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish in Homebrew #71

Closed
jsixface opened this issue Oct 18, 2018 · 21 comments
Closed

Publish in Homebrew #71

jsixface opened this issue Oct 18, 2018 · 21 comments

Comments

@jsixface
Copy link
Contributor

jsixface commented Oct 18, 2018

Make gitql available through homebrew to be installed via command brew install gitql
A sub-task of #63

I'll start working on this first

@jsixface
Copy link
Contributor Author

@cloudson if libgit2 library is already installed in the system, can we go ahead and build gitql directly with go build. Assuming the dynamic library path is setup.

@filhodanuvem
Copy link
Owner

Looks a good idea @jsixface .

@jsixface
Copy link
Contributor Author

@cloudson I was trying a ask a question there 😃 . Trying to find out why the fork libgit2 and git2go was used rather than original repos. If tagging to a specific version is needed the new dependency manager in go can help.

@filhodanuvem
Copy link
Owner

That's the exact reason @jsixface . At that time we had (I guess) just go get and I remember that in few days using the original repos we had a lot of problems. Do you think that go dep can solve it?

@jsixface
Copy link
Contributor Author

That makes sense. Yeah dep can solve the versioning issue and can stick to a specific tag. That way we make libgit2 a system dependency and have gitql as installable software.

@humblefool1997
Copy link

@cloudson is this still open , if yes would like to work on it

@filhodanuvem
Copy link
Owner

@isaeef definetly it's open and we would love to get your help. 😊

@ankane
Copy link

ankane commented Jul 10, 2020

Hey @filhodanuvem, I created a formula here: https://github.com/ankane/homebrew-core/blob/master/Formula/gitql.rb

However, it fails with:

error: "Invalid libgit2 version; this git2go supports libgit2 v0.27"
# error "Invalid libgit2 version; this git2go supports libgit2 v0.27"
  ^
1 error generated.

Is it possible to support the latest version of libgit2 (1.0.1)?

@renatosuero
Copy link

what about use to release new version including homebrew?

@filhodanuvem
Copy link
Owner

filhodanuvem commented Sep 15, 2020

First of all, thanks for the effort @ankane, I just notice your message now, so sorry for the late.
Currently gitql depends of git2go, which uses the libgit2. It seems that git2go supports libgit2 1.0, so we could upgrade and check it.

@ankane
Copy link

ankane commented Sep 17, 2020

Great, happy to test again once #94 is merged (fwiw, it looks like there are some references in the code to cloudson/git2go that aren't in the PR).

@filhodanuvem
Copy link
Owner

filhodanuvem commented Sep 17, 2020

Just a question, in the formula, can we freeze the libgit2 to 1.0.1? I'm worried that in few months it will start breaking because in gitql is not going to require the latest version of git2go/libgit2.

@ankane
Copy link

ankane commented Sep 17, 2020

Homebrew has a few versioned formula, but from my understanding, it's only for very popular packages (the current libgit2 formula always references the latest version). With the 1.0 release, all 1.x releases should be backward compatible according to the release notes:

This is release v1.0 "Luftschloss", which is the first stabe release of
libgit2. The API will stay compatible across all releases of the same major
version.

@filhodanuvem
Copy link
Owner

@ankane we just made a change that remove the libgit2 dependency, if you are able to try again on homebrew that would be awesome. I'm closing #94 since it's not needed anymore.

@ankane
Copy link

ankane commented Oct 4, 2020

@filhodanuvem works great. Will submit whenever a new release is out.

@filhodanuvem
Copy link
Owner

Done @ankane

@ankane
Copy link

ankane commented Oct 4, 2020

Great, submitted: Homebrew/homebrew-core#62091

@filhodanuvem
Copy link
Owner

Thank you so much @ankane

@ankane
Copy link

ankane commented Oct 5, 2020

brew install gitql

is now available.

@filhodanuvem
Copy link
Owner

Amazing! Thanks a lot @ankane for the effort. I'm closing this.

@ankane
Copy link

ankane commented Oct 5, 2020

np, thanks for updating the project to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants