Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkcheck Internal errors and Unhandled exception #35

Closed
zomdir opened this issue Apr 6, 2019 · 5 comments
Closed

Linkcheck Internal errors and Unhandled exception #35

zomdir opened this issue Apr 6, 2019 · 5 comments

Comments

@zomdir
Copy link

zomdir commented Apr 6, 2019

Hi Filip,

Again compliments. Linkcheck is the fastest linkchecker I'm aware of. Here are some issues I've found.

Best regards,
Hans

$ linkcheck wordpress.org
Crawling: 459INTERNAL ERROR: Sorry! Please open https://github.com/filiph/linkcheck/issues/new in your favorite browser and copy paste the following output there:

Invalid argument(s): Text "" must be 73 characters long.

736INTERNAL ERROR: Sorry! Please open https://github.com/filiph/linkcheck/issues/new in your favorite browser and copy paste the following output there:

Invalid argument(s): Text "" must be 128 characters long.

$ linkcheck https://autorijschoolokido.nl/
Crawling: 96Unhandled exception:
NoSuchMethodError: The getter 'primaryType' was called on null.
Receiver: null
Tried calling: primaryType
#0 Object.noSuchMethod (dart:core/runtime/libobject_patch.dart:50:5)
dart-lang/tools#1091 DestinationResult.updateFromResponse (package:linkcheck/src/destination.dart:327:48)
dart-lang/html#2 checkPage (package:linkcheck/src/worker/worker.dart:127:11)

dart-archive/html#3 worker. (package:linkcheck/src/worker/worker.dart:192:29)

dart-archive/html#4 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10)
dart-archive/html#5 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)
dart-archive/html#6 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)
dart-lang/html#7 _SyncStreamController._sendData (dart:async/stream_controller.dart:764:19)
dart-lang/tools#1094 _StreamController._add (dart:async/stream_controller.dart:640:7)
dart-lang/tools#1095 _StreamController.add (dart:async/stream_controller.dart:586:5)
dart-archive/html#10 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10)
dart-archive/html#11 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)
dart-lang/tools#1096 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)
dart-archive/html#13 _SyncStreamController._sendData (dart:async/stream_controller.dart:764:19)
dart-lang/html#14 _StreamController._add (dart:async/stream_controller.dart:640:7)
dart-lang/html#15 _StreamController.add (dart:async/stream_controller.dart:586:5)
dart-lang/tools#1099 _StreamSinkWrapper.add (dart:async/stream_controller.dart:858:13)
dart-lang/tools#1100 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10)
dart-lang/html#18 CastStreamSubscription._onData (dart:_internal/async_cast.dart:81:11)
dart-lang/tools#1102 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10)
dart-lang/tools#1103 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)
dart-lang/tools#1104 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)
dart-lang/tools#1105 _SyncStreamController._sendData (dart:async/stream_controller.dart:764:19)
dart-lang/html#23 _StreamController._add (dart:async/stream_controller.dart:640:7)
dart-lang/tools#1107 _StreamController.add (dart:async/stream_controller.dart:586:5)
dart-lang/tools#1108 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
97Unhandled exception:
NoSuchMethodError: The getter 'primaryType' was called on null.
Receiver: null
Tried calling: primaryType
#0 Object.noSuchMethod (dart:core/runtime/libobject_patch.dart:50:5)
dart-lang/tools#1091 DestinationResult.updateFromResponse (package:linkcheck/src/destination.dart:327:48)
dart-lang/html#2 checkPage (package:linkcheck/src/worker/worker.dart:127:11)

dart-archive/html#3 worker. (package:linkcheck/src/worker/worker.dart:192:29)

dart-archive/html#4 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10)
dart-archive/html#5 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)
dart-archive/html#6 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)
dart-lang/html#7 _SyncStreamController._sendData (dart:async/stream_controller.dart:764:19)
dart-lang/tools#1094 _StreamController._add (dart:async/stream_controller.dart:640:7)
dart-lang/tools#1095 _StreamController.add (dart:async/stream_controller.dart:586:5)
dart-archive/html#10 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10)
dart-archive/html#11 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)
dart-lang/tools#1096 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)
dart-archive/html#13 _SyncStreamController._sendData (dart:async/stream_controller.dart:764:19)
dart-lang/html#14 _StreamController._add (dart:async/stream_controller.dart:640:7)
dart-lang/html#15 _StreamController.add (dart:async/stream_controller.dart:586:5)
dart-lang/tools#1099 _StreamSinkWrapper.add (dart:async/stream_controller.dart:858:13)
dart-lang/tools#1100 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10)
dart-lang/html#18 CastStreamSubscription._onData (dart:_internal/async_cast.dart:81:11)
dart-lang/tools#1102 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10)
dart-lang/tools#1103 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)
dart-lang/tools#1104 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7)
dart-lang/tools#1105 _SyncStreamController._sendData (dart:async/stream_controller.dart:764:19)
dart-lang/html#23 _StreamController._add (dart:async/stream_controller.dart:640:7)
dart-lang/tools#1107 _StreamController.add (dart:async/stream_controller.dart:586:5)
dart-lang/tools#1108 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
102
^C
Ctrl-C Terminating crawl.
@filiph
Copy link
Owner

filiph commented May 27, 2019

Sorry for not seeing this earlier.

I'm afraid this is a known issue, it's to do with unicode in some places of HTML, and it's blocked on dart-lang/tools#1009. I did not realize it's as widespread as being on wordpress.org, though. :/

@b4stien b4stien mentioned this issue Sep 27, 2019
Open
@b4stien
Copy link

b4stien commented Sep 27, 2019

@filiph the upstream issue is fixed, do you think it's possible to release a version with the dependency pinned to dart-archive/html@2b392a4?

@filiph
Copy link
Owner

filiph commented Sep 27, 2019

This is amazing news! Unfortunately, I cannot publish a version on pub that depends on a git-only version. dart-archive/html#109 needs to first make it onto pub.

One complication could be that package:html is also a transitive dependency of source_span (through which the unicode bug actually manifests). And that package may also need updating. But we'll worry about it when we get there, I guess.

@nshahan
Copy link

nshahan commented Sep 30, 2019

@filiph I published an updated version. html v0.14.0+3

@filiph filiph closed this as completed in 1945e3f Sep 30, 2019
@filiph
Copy link
Owner

filiph commented Sep 30, 2019 •
edited
Loading

Thank you @nshahan!

I just published version 2.0.11 of linkcheck that no longer has the unhandled exception issue.

@nank1ro nank1ro mentioned this issue Feb 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@filiph @b4stien @nshahan @zomdir