Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade of cnb-api #3

Open
pionl opened this issue Feb 13, 2023 · 3 comments
Open

Upgrade of cnb-api #3

pionl opened this issue Feb 13, 2023 · 3 comments
Assignees
Milestone

Comments

@pionl
Copy link
Contributor

pionl commented Feb 13, 2023

hi,

I've checked the package and thank you for it!

I wanted to contribute the codebase with an "Client" interface so I can make a test (without mocks). But I've noticed issues due the PHP versions constraints. I had to update:

PHPStan:
Seems ok, few errors that can be fixed

coding standard:
I had to enable plugin to use it. Fails on ERROR: Referenced sniff "SlevomatCodingStandard.TypeHints.TypeHintDeclaration" does not exist

tester:
Fails to run, : No such file or directory

I was thinking what is your plan? Are you interested in upgrade?

I could do this:

Thanks and have a good day,

@filipsedivy
Copy link
Owner

Hello,

thank you for your feedback.

There is now a v4.0 branch under development, in which comments will be reflected. Support for PHP 8 is planned, as well as rewriting the code to a cleaner form.

I believe this update will take effect quickly.

Thanks for the comments!

@filipsedivy filipsedivy added this to the v4.0 milestone Feb 13, 2023
@pionl
Copy link
Contributor Author

pionl commented Feb 14, 2023

Thanks for the info, I can confirm that the code is running on 8.1 without any warnings (so far) 👍

Do you need any help?

@pionl
Copy link
Contributor Author

pionl commented Feb 14, 2023

Try the rector php, it will automatically upgrade the code to PHP 8.0 conventions (so you can focus on other stuff) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants