Fatal error: Class 'Symfony\Component\VarDumper\Cloner\VarCloner' not found

[kinglozzer]

Fatal error: Class 'Symfony\Component\VarDumper\Cloner\VarCloner' not found in /***/vendor/filp/whoops/src/Whoops/Handler/PrettyPageHandler.php on line 122

Appears to have been caused by #404, as 2.1.0 works fine. symfony/var-dumper is only in require-dev - so it isn’t installed for packages that require filp/whoops.

[GrahamCampbell]

Doesn't look like a bug. It's in the suggests list: https://github.com/filp/whoops/blob/master/composer.json#L23.

[GrahamCampbell]

That means if you want to use that feature, you need to add that dependency yourself. That's why composer dumps out a list of suggested packages when you run install.

[kinglozzer]

So symfony/var-dumper is a requirement if you want to use PrettyPageHandler? That should be documented somewhere if that’s the case...

[GrahamCampbell]

So symfony/var-dumper is a requirement if you want to use PrettyPageHandler? That should be documented somewhere if that’s the case...

It is documented?

[denis-sokolov]

This does, indeed, look like a bug. Anyone up to fix it? @jonasdt?

[GrahamCampbell]

This does, indeed, look like a bug.

How is this a bug? We clearly have included this in the suggested dependencies, and we should not be forcing people to install this. Composer will clearly print to the screen that it's suggested, and it'll even tell you why too.

[kinglozzer]

PrettyPageHandler, prior to 2.1.1, has never required that package to be installed. So it’s either a bug, or a pretty significant backward compatibility break

[GrahamCampbell]

I'd say that much is a bug then. ;)

[jonasdt]

symfony/var-dumper is indeed a requirement if you want to use PrettyPageHandler, this was not the case before #404, this is the culprit

[jonasdt]

Any reason why this isn't a dependency?

[denis-sokolov]

We don’t want the users to require the var-dumper, it’s supposed to be optional. @jonasdt, can you adjust your code to be conditional on the VarDumper existing?

[kinglozzer]

Any reason why this isn't a dependency?

Well it was originally added as a suggested package, with usage of it wrapped in class_exists(): 6a1c86b

Since then it has been added to require-dev, and that particular class_exists() check has been removed - #387 & #404

Edit: I was reading the diff wrong, the class_exists() check in TemplateHelper is still there :)

[jonasdt]

I'll push a fix today