Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to add labels to ghcMetrics? If yes, how? #52

Closed
alaendle opened this issue Jan 14, 2020 · 1 comment
Closed

Is it possible to add labels to ghcMetrics? If yes, how? #52

alaendle opened this issue Jan 14, 2020 · 1 comment

Comments

@alaendle
Copy link
Contributor

Sorry if this is a silly question, but I found no obvious way to add labels to the metrics exposed by ghcMetrics. I plan to aggregate the exposed prometheus text of multiple service instance and so I'm looking for a way to distinguish the instances - I think prometheus labels might be a good way to do so. For sure labels could maybe added during scraping; but I think the running application has much more context information to add reasonable labels/values.
alaendle added a commit to alaendle/prometheus-haskell that referenced this issue Jan 15, 2020
@alaendle
Added possability to label GHC metrics (and removed GHC 8.0 support)
0c4409d 
Quick hack to include Prometheus labels in GHC metrics - solves fimad#52.
Please note that this was just a 'hack' to add labels - but it maybe it could be used as a starting point for this feature.
@alaendle alaendle mentioned this issue Jan 15, 2020
Merged
@ocharles
Copy link
Collaborator

Fixed by #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocharles @alaendle