Added possability to label GHC metrics #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick hack to include Prometheus labels in GHC metrics - solves fimad#52. Please note that this was just a 'hack' to add labels - but it maybe it could be used as a starting point for this feature.
|
Other than removing the |
alaendle
changed the title
|
✋ @fimad Just to let you know, I think this PR has reached a level that is stable enough to be reviewed; but for sure don't want to rush you - it has time |
ocharles
approved these changes
Jan 25, 2020
|
Thank you for the cooperation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick hack to include Prometheus labels in GHC metrics - solves #52.
Please note that this was just a 'hack' to add labels - but it maybe it could be used as a starting point for this feature.