Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestItem doesn't have to be on Endpoint #890

Closed
vkostyukov opened this issue Jan 3, 2018 · 2 comments
Closed

RequestItem doesn't have to be on Endpoint #890

vkostyukov opened this issue Jan 3, 2018 · 2 comments
Labels
cleanup
Milestone
Finch 1.0

Comments

@vkostyukov
Copy link
Collaborator

It's not used as of 0.16. Let's remove it for now. Ideally, it has to be replaced with something like Error.Source (see #787) or a metadata (see #581).
@vkostyukov vkostyukov added this to the Finch 0.17 milestone Jan 3, 2018
@vkostyukov
Copy link
Collaborator Author

Looks like we have to remove should* methods from the Endpoint first. This relates to #513.

@vkostyukov vkostyukov modified the milestones: Finch 1.0, Finch 0.19 Mar 18, 2018
@vkostyukov vkostyukov modified the milestones: Finch 0.19, Finch 0.20 Apr 13, 2018
@vkostyukov vkostyukov modified the milestones: Finch 0.21, Finch 0.22 Jun 16, 2018
@joroKr21
Copy link
Collaborator

Removed in #1471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
Finch 1.0
Development

No branches or pull requests
2 participants
@vkostyukov @joroKr21