-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetching quotes from XETRA (Frankfurt stock exchange) #151
Conversation
I do not see the benefit. According https://code.gnucash.org/docs/C/gnucash-help/fq-spec-yahoo.html you can get it from yahoo_json by appending ".DE" to the ISIN. |
Apologies, I was not aware of that page. However, the ISIN in the example above does not seem to work. Is it a problem on my end? |
https://www.xetra.com/xetra-en/instruments/shares/list-of-tradable-shares/xetra/4750!search?query=DE000A0D8Q07 says
|
Perhaps it does not work because it's an ETF? The ISIN is correct and the quotes are at https://www.boerse-frankfurt.de/en/etf/ishares-euro-stoxx-ucits-etf-de |
OK, then your module will also fetch ETFs. That should be mentioned in its docs. Note: .F (Börse Frankfurt) and .DE (XETRA) are 2 different markets with slightly different quotes. .F is the traditional exchange and .DE its electronic counterpart. Run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frankfurt and Xetra are different exchanges.
Please note, the modules are listed in Modules-README.yml alphabetically. The maintainers also ask that a respective test suite be written and placed in the t/ directory with the other test suites. Include at least one test that should fail. See the other test files for examples. |
Once the additional line about where to find the full list of symbols is added to the documentation, are we happy with this PR? |
I will write tests in a few days, sorry for the delay! |
I just merged pull request #149, which changed Quote.pm. Pull from master and merge into your branch. |
Done, is anything else required? |
Thanks! I'm going to work on merging pull requests this weekend. |
Hi, is Xetra.pm still experimental or already outdated? The module is in the Finance/Quote folder, but not listed in quote.pm. If I add it there, Finance::Quote complains that there is no method "xetra" found. |
The URL is no longer valid, thereby breaking the module. It will be removed completely from the next release of F::Q. |
Yes, there have been changes |
@fellen I got that URL via the web developer tools on their website. But with the new redesign they added some countermeasures to make it harder to get that data and I cannot figure out how to get the quotes. |
@e-dorigatti - Unfortunately this is not the only module this has happened to over the last few years. If and when you find it can be resurrected, please create another pull request with the update version of the module (and test file). Thank you for your contributions. Bruce S. |
So I suggest to remove the "next release" label and add the "module malfunction" label. |
The labels on pull requests and issues are assigned soon after they are created. When created, PR #151 was going into the next release (I think that was 1.50). While labels may change while the issue or PR is open, they are not changed once closed. For a good reference of how it was classified when actively being addressed. There are now quite a few modules that have been added in the past that currently do not work. The F::Q team is not about to go through every past PR and change labels for those modules. What we have been doing is updating the Modules-README.yml file. Here one can view the state of the module when last tested (yes, some are still TBD), the URL/URI used for fetching the data, and test cases used in the t/mymodule.t test files. You will find that the Modules-README.yml file will get updated a few times between releases. Thank you. |
Hi, I contributed a new module to fetch quotes from the frankfurt stock exchange, which provides a JSON endpoint. As I am new to perl, I based the module on
yahoo_json
and made the necessary modifications.I don't know what is your policy on testing, but I can run the example script successfully: