Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

May be able to remove or we may have broken case-sensitive logic #47

Closed
matthew-andrews opened this issue May 17, 2014 · 3 comments
Closed

Comments

@matthew-andrews
Copy link
Contributor

@orangemug ... I just re-discovered this code:-
https://github.com/ftlabs/ftdomdelegate/blob/master/lib/delegate.js#L185

Did we break this when I merged: #45 ?

It makes sense that SVG is case sensitive (it's XML based) but not modern HTML.

Actually do you know what, I don't think we should be supporting the following to be different:-

del.on('click', 'DIV', function() {
  console.log('i\'m a capital div');
});
del.on('click', 'div', function() {
  console.log('i\'m a lowercase div');
});

Do you think it would be sensible to just lowercase all the tags and remove this (now redundant) logic?

@orangemug
Copy link
Contributor

Can you think of any use case where you'd want case sensitive tag names? (I can't)

@matthew-andrews
Copy link
Contributor Author

I added some commits to my pull request (bad matt). Turns out we weren't even testing for it either...

#46

@matthew-andrews
Copy link
Contributor Author

I think this is fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants