Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Directory main endpoint and other examples don't match the JSON schema at interop.intents.raises #1085

Closed
BalassaMarton opened this issue Oct 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@BalassaMarton
Copy link

Area of Issue

[x] App Directory
[ ] API
[ ] Context Data
[ ] Intents
[ ] Desktop Agent Bridging
[ ] Use Cases
[ ] Other

Issue Description:

According to the spec, raises should map intent names to list of context types:
https://github.com/finos/FDC3/blob/master/src/app-directory/specification/appd.schema.json#L816-L827

But the JSON returned by the AppD main endpoint uses the same schema as for listensFor (a map from intent name to intent metadata).
Example: https://github.com/finos-labs/FDC3-App-Directory/blob/main/_apps/adaptabledemo.json#L64-L78

I'm not sure if this is an error in the JSON schema or the examples.

Additional Context:

FDC3-Sail also has an example JSON file with a non-compliant element: https://github.com/finos/FDC3-Sail/blob/44873c90b99925ac93f9c339407547a1a6652764/directory/local.v2.json#L581-L600

@kriswest
Copy link
Contributor

kriswest commented Oct 4, 2023

@BalassaMarton Thank you for reporting this.
I can confirm that the spec is as intended and that the schema for interop.intents.raises and interop.intents.listensFor are different (listensFor has multiple properties to contain for each intent name, raises does not so it is just an array of contexts for each intent name).
image

@robmoffat both Sail and the FINOS app directory should be corrected to match the spec. I've raised issues on both and will close this one, see:

@kriswest kriswest closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants