-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons spec #319
Icons spec #319
Conversation
@@ -347,9 +347,15 @@ components: | |||
Icon: | |||
description: Icon holder | |||
properties: | |||
icon: | |||
src: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. Considering that this is meant to be part of the "2.0" release I thought that it would be I acceptable.
If not, I suggest to either
- not introduce
src
and use theicon
property as image url - deprecate icon in favour of a newly added
src
property. In that case Desktop Agent may treaticon
as it would treatsrc
|
||
### `src` | ||
|
||
The fully qualified url to the icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that in the PWA manifest spec the url may be relative. However in the context of FDC3 I couldn't find where a Desktop agent may retrieve the base url of an application so that when given a relative url it could construct the fully qualified url.
That is the reason why only fully qualified url are allowed here.
@rikoe - would you mind having a look at that PR when have some free time? |
@pgn-vole do you mind resolving the conflicts (rebasing), then we can merge this one in? |
@rikoe it should be good now. |
Improves App Metadata icons specification. It is heavily based on PWA manifest's icon spec.
Fixes #257