Icons spec #319
Icons spec #319
Conversation
| @@ -347,9 +347,15 @@ components: | |||
| Icon: | |||
| description: Icon holder | |||
| properties: | |||
| icon: | |||
| src: | |||
There was a problem hiding this comment.
This is a breaking change. Considering that this is meant to be part of the "2.0" release I thought that it would be I acceptable.
If not, I suggest to either
- not introduce
srcand use theiconproperty as image url - deprecate icon in favour of a newly added
srcproperty. In that case Desktop Agent may treaticonas it would treatsrc
|
|
||
| ### `src` | ||
|
|
||
| The fully qualified url to the icon. |
There was a problem hiding this comment.
Please note that in the PWA manifest spec the url may be relative. However in the context of FDC3 I couldn't find where a Desktop agent may retrieve the base url of an application so that when given a relative url it could construct the fully qualified url.
That is the reason why only fully qualified url are allowed here.
|
@rikoe - would you mind having a look at that PR when have some free time? |
|
@pgn-vole do you mind resolving the conflicts (rebasing), then we can merge this one in? |
|
@rikoe it should be good now. |
Improves App Metadata icons specification. It is heavily based on PWA manifest's icon spec.
Fixes #257