Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move icons property type definition into Types page in website #493

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

kriswest
Copy link
Contributor

@kriswest kriswest commented Nov 9, 2021

When added by PR #319 the Icon reference was not added to the navigation. To resolve, this PR moves the Icon type definition into the Types page for consistency with other types.

A small formatting fix for an item in the metadata page is also included

@rikoe
Copy link
Contributor

rikoe commented Nov 9, 2021

Needs Changelog change I guess ;-)

@kriswest kriswest merged commit 37c66f1 into finos:master Nov 12, 2021
@kriswest kriswest deleted the Add-icons-reference-to-metadata-page branch November 12, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants