Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Design UX for changing a color #529

Closed
aaronreed708 opened this issue Sep 8, 2023 · 4 comments
Closed

[REQUEST] Design UX for changing a color #529

aaronreed708 opened this issue Sep 8, 2023 · 4 comments
Assignees
Labels
design thinking enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed theme builder app Theme Builder application

Comments

@aaronreed708
Copy link
Contributor

Suggestion/Concern

Currently it isn't possible in Theme Builder to change a color in a color palette. Only new colors can be added. One of the reasons for the current limitation is the fallout that would happen due to a change and the fallout may not be completely managed without human intervention. For example, what happens to all of the molecules that were already using the original color? What if the original color was the primary, secondary or tertiary color defined in the default color theme? Which other default color theme values would be impacted? Which atoms depend on the affected color theme? Which "on" colors would need to be recalculated? The goal of this issue is to design how a color change could be made by the user, how the application would communicate the impending issues to the user, what default values could be used until the user makes the manual updates, how is the user made aware of what manual updates need to be made, etc

Proposed Solution

@aaronreed708 aaronreed708 added enhancement New feature or request good first issue Good for newcomers theme builder app Theme Builder application labels Sep 8, 2023
@aaronreed708
Copy link
Contributor Author

Related to #664

@Turntabl-DorothyEwuah
Copy link

Will be working on this issue.

@aaronreed708
Copy link
Contributor Author

aaronreed708 commented May 2, 2024

I believe that this issue was probably accomplished in the effort for #738. Do you agree @lwnoble? If so, I think that we can close.

@aaronreed708
Copy link
Contributor Author

@lwnoble agrees that this is accomplished in #738. So closing.

@aaronreed708 aaronreed708 removed the awaiting feedback Issue is blocked until awaiting feedback label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design thinking enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed theme builder app Theme Builder application
Projects
Status: Done
Development

No branches or pull requests

5 participants