Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Support file/path exclusions #123

Open
rikoe opened this issue Apr 17, 2019 · 4 comments
Open

Support file/path exclusions #123

rikoe opened this issue Apr 17, 2019 · 4 comments

Comments

@rikoe
Copy link

rikoe commented Apr 17, 2019

It would be great if cla-bot supported configuring what type and/or locations of files to monitor for changes.

E.g. if you can specify *.md or /docs/**/* to exclude particular files or folders from CLA checks.

@ColinEberhardt
Copy link
Contributor

Hi @rikoe - it would be good if you could describe the underlying use-case here?

Is it that there are certain files / folders where you'd like to accept changes from users who have not signed the CLA?

@rikoe
Copy link
Author

rikoe commented Apr 17, 2019

The underlying use case is that for some content in the repo, CLA may not be required (or so I am told), and only for code submissions. So this would allow turning off CLA scanning for e.g. markdown files.

@ColinEberhardt
Copy link
Contributor

Ok, could be a useful feature, but would be relatively complex, requiring extra API call to determine the files ‘touched’ by each commit within a PR.

I also wonder about the licensing issues, feels like it would open up a whole can of worms? Markdown files, config, documentation are all part of the project, and surely need a CLA to ensure the a contributor has the rights to the changes they have committed and are happy to have them redistributed under the projects OSS licence.

@rikoe
Copy link
Author

rikoe commented Apr 17, 2019

@ColinEberhardt all good points. Let me loop back to FINOS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants