Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Cannot verify commits from authors that do not have GitHub accounts #94

Open
ColinEberhardt opened this issue May 31, 2018 · 2 comments

Comments

@ColinEberhardt
Copy link
Contributor

The code looks for commit.author.login, however this is the payload we see for these authors:

 "commit": {
                "author": {
                    "name": "---,
                    "email": "---",
                    "date": "2018-04-26T00:19:43Z"
                },
                "committer": {
                    "name": "---",
                    "email": "---",
                    "date": "2018-04-26T00:19:43Z"
                },
                "message": "Demoved duplicate quote",
                "tree": {
                    ...
                },
@maoo
Copy link
Member

maoo commented May 31, 2018

Looks very similar to https://github.com/ColinEberhardt/cla-bot/issues/74 , right? Would be great to generate a list of {{ unknownUsers }} that can be mentioned in the .clabot message, containing the list of commit.author.name that cannot be resolved by GitHub APIs. wdyt?

@ColinEberhardt
Copy link
Contributor Author

Hi @maoo you're absolutely right, that is the same.

As an alternative, I was thinking of allowing the contributors array to contain a combination of GitHub IDs or email addresses.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants