Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Post Filter in Query Editor #839

Closed
13 tasks done
Tracked by #256
njerigrevious opened this issue Feb 8, 2022 · 1 comment · Fixed by #902
Closed
13 tasks done
Tracked by #256

Feature request: Post Filter in Query Editor #839

njerigrevious opened this issue Feb 8, 2022 · 1 comment · Fixed by #902
Assignees
Labels
Component: Query Builder Issues related to query builder core Studio Core Team Opened by a member of the Studio core team Type: Feature Request
Milestone

Comments

@njerigrevious
Copy link

njerigrevious commented Feb 8, 2022

Similar requests

  • I have searched and found no existing similar requests

How are you using Studio?

Legend Query

What problems are you trying to solve?

Many users have requested the ability to perform a post-filter rather than a regular filter in Query. Post filters allow you to perform filter operations on the Tabular Data Structure TDS structure returned by the project function.

Describe the solution you would like to see implemented

  • Add TDSRow class to graph
  • Add value specification processing of filter on projection
  • Add query builder processing on filter on projection
  • Add lambda builder processing on filter on projection
  • FORM MODE
    • add post filter panel
    • add support for hiding/showing panel. default should hide
    • DND for projection columns
      • disable for graph fetch
      • auto generate filter lambda based on column
      • handle derivation columns (should use engine return type api to generate correct post filter lambda)
      • enable group filter just like in regular filter

Sample Query to Support

|model::Person.all()->project(
  [
    x|$x.firstName,
    x|$x.lastName
  ],
  [
    'First Name',
    'Last Name'
  ]
)->filter(
  row|$row.getString('First Name') == 'John'
)
@njerigrevious njerigrevious added Type: Feature Request Application: Query Issues related to Legend Query application labels Feb 8, 2022
@njerigrevious njerigrevious added this to the 4.0.0 milestone Feb 8, 2022
@github-actions github-actions bot added the Studio Core Team Opened by a member of the Studio core team label Feb 8, 2022
@akphi akphi added Component: Query Builder Issues related to query builder core and removed Application: Query Issues related to Legend Query application labels Feb 8, 2022
@akphi
Copy link
Contributor

akphi commented Feb 8, 2022

@njerigrevious the correct label to use for this is Component: Query Builder, not Application: Query since this refers to the shared part that even Studio can use. Please note that next time. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Builder Issues related to query builder core Studio Core Team Opened by a member of the Studio core team Type: Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants