Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output keys to datasets produced by RUN_MODEL and RUN_FLOW jobs #221

Closed
martin-traverse opened this issue Dec 9, 2022 · 2 comments
Closed

Comments

@martin-traverse
Copy link

Feature Request

For RUN_MODEL jobs the key should be the model output key while for RUN_FLOW jobs the key should be the name of the flow output node. These should be controlled attrrs (i.e. .named trac_*). We need to decide whether to use the same attr for model and flow outputs, or whether to use different ones.

Description of Problem:

Currently there is no standard controlled tag attr added to job outputs by TRAC. Attrs can be added by configuring a flow/job to add them, but we want a standard contrtolled tag that is always supplied by TRAC and cannot be editted by users, as part of the audit history of where a dataset came from.

Potential Solutions:

See above.

@mslapek
Copy link
Contributor

mslapek commented Jan 2, 2023

@martin-traverse What do you understand as key in that context?

There is only objectId in RunModelJob.model...

@martin-traverse
Copy link
Author

This is already done, trac_job_output is added to every output created by a job. For RunModelJob the output key is the model output key, for RunFlowJob the output key is the flow output node name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants