Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approvedpush 20241205 basket off #1060

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Approvedpush 20241205 basket off #1060

wants to merge 21 commits into from

Commits on Dec 5, 2023

  1. finos#966 when updating basket trade cell value, only update if diffe… 

    …rent from current value
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    436c889 View commit details
    Browse the repository at this point in the history

  2. finos#982 initial implementation of editing basket trade constituent … 

    …side
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    c4c6afb View commit details
    Browse the repository at this point in the history

  3. finos#979 using unique instanceId for the basket trade separate from … 

    …basket trade name entered by user
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    6463da7 View commit details
    Browse the repository at this point in the history

  4. finos#980 adding basket trading constituent row - using menu for testing

    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e0d905d View commit details
    Browse the repository at this point in the history

  5. finos#980 removed the add row menu that was for testing, clean up and… 

    … error handling around adding row
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    9d23e74 View commit details
    Browse the repository at this point in the history

  6. finos#980 returning no action for menu calls and rcp success or failu… 

    …re for rcp call
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    79fd6a2 View commit details
    Browse the repository at this point in the history

  7. finos#1010 registring ViewPortRpcSuccess

    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a6d3173 View commit details
    Browse the repository at this point in the history

  8. finos#979 updated test to use basket trade instance id seperate from … 

    …basket name. Disabling tests that are in progress
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    2441862 View commit details
    Browse the repository at this point in the history

  9. finos#1010 re-naming to VP_EDIT_FAILURE and VP_RCP_FAILURE for consis… 

    …tency
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    351a5b2 View commit details
    Browse the repository at this point in the history

  10. finos#1019 converting weighting and limit price field to a double as … 

    …json serialisation parse it as BigDecimal or Integer
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    f5a41e6 View commit details
    Browse the repository at this point in the history

  11. finos#979 moved logic for generating unique basket id to the static c… 

    …lass, using that class to get generated basket trade if in tests
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b2cae8a View commit details
    Browse the repository at this point in the history

  12. finos#980 making basket trade add constituent take in single ric as p… 

    …arsing arrays on rcp message is not supported
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    90eaa31 View commit details
    Browse the repository at this point in the history

  13. finos#1025 updating internal order state's state when processing fill

    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    6390950 View commit details
    Browse the repository at this point in the history

  14. finos#1025 implementing taking basket trade off the market

    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5bf65d0 View commit details
    Browse the repository at this point in the history

  15. finos#1025 using MAX_FILL_TIME_MS when generating random next event time

    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b898042 View commit details
    Browse the repository at this point in the history

  16. finos#1025 updated basket send to market test to include taking off t… 

    …he market
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    dc35263 View commit details
    Browse the repository at this point in the history

  17. finos#1027 fix for where basket constituent is not sorting

    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b83cfbb View commit details
    Browse the repository at this point in the history

  18. finos#1036 adding equals and hashcode override methods to be able to … 

    …compare ViewPortColumns
    @naleeha
    naleeha committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ec58b40 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. finos#1010 correcting name of RPC response message

    @naleeha
    naleeha committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    c57daf3 View commit details
    Browse the repository at this point in the history

  2. finos#980 adding description to the new constituent on basket trading

    @naleeha
    naleeha committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f6de416 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. finos#1059 removed the redundant sides constants and made buy and sel… 

    …l all upper case everywhere
    @naleeha
    naleeha committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    71cf561 View commit details
    Browse the repository at this point in the history