Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing number fields on constituents set it to incorrect type #1019

Closed
naleeha opened this issue Nov 27, 2023 · 1 comment
Closed

Editing number fields on constituents set it to incorrect type #1019

naleeha opened this issue Nov 27, 2023 · 1 comment
Assignees
@naleeha
Labels
bug Something isn't working

Comments

@naleeha
Copy link
Contributor

naleeha commented Nov 27, 2023

Bug Report

Steps to Reproduce:

  1. Load Basket trading feature, create a basket
  2. Edit weighting for a basket trade constituent
  3. Change the basket trade Unit on top

Expected Result:

Basket Trade Constituent should show the updated weight
The quantity of the basket trade constituents should update to take account of basket trade unit

Actual Result:

Basket Trade Constituent weight field is blank
type cast error on basket trade unit
image
@naleeha naleeha moved this to 🆕 New in Vuu board Nov 27, 2023
@naleeha naleeha added the bug Something isn't working label Nov 27, 2023
@naleeha naleeha changed the title Editing number fields set it to incorrect type Editing number fields on constituents set it to incorrect type Nov 27, 2023
@naleeha naleeha moved this from 🆕 New to 🏗 In progress in Vuu board Nov 27, 2023
@naleeha naleeha self-assigned this Nov 27, 2023
@naleeha
Copy link
Contributor Author

naleeha commented Nov 27, 2023

Need proper look at json desrialisation for number types
Also need to prevent DataTable being updated with different types from table def

For now added workaround to cast weigthing cell update on Basket trading constituent table to Double

@naleeha naleeha moved this from 🏗 In progress to 🔖 Ready in Vuu board Nov 27, 2023
@naleeha naleeha moved this from 🔖 Ready to 👀 In review in Vuu board Nov 28, 2023
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue Dec 5, 2023
@naleeha
finos#1019 converting weighting and limit price field to a double as …
82931ad 
…json serialisation parse it as BigDecimal or Integer
chrisjstevo pushed a commit that referenced this issue Dec 5, 2023
@naleeha @chrisjstevo
#1019 converting weighting and limit price field to a double as json …
0de3dbd 
…serialisation parse it as BigDecimal or Integer
@naleeha naleeha moved this from 👀 In review to ✅ Done in Vuu board Dec 7, 2023
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue Dec 7, 2023
@naleeha
finos#1019 converting weighting and limit price field to a double as …
f5a41e6 
…json serialisation parse it as BigDecimal or Integer
@naleeha naleeha closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naleeha naleeha

Labels
bug Something isn't working
Projects
Vuu board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@naleeha