call offAuth() with correct method. #473
Conversation
|
Cheers, @jamestalmage, thanks for all the great contributions! Jacob is busy with some server issues tonight but he'll review this soon (since he wrote the auth portion of the latest release) and get back to you. |
|
No problem. Glad to help. |
| deferred.resolve(null); | ||
| _routerMethodOnAuthPromise: function(rejectIfAuthDataIsNull) { | ||
| var ref = this._ref, | ||
| deferred = this._q.defer(); |
There was a problem hiding this comment.
Define variables on separate lines with their own var.
|
This is a great change. I really appreciate all the issues and PRs you've contributed over the past few days. It's honestly great to see. I made a few stylistic comments which I'd like you to make just to be consistent with the rest of the AngularFire lib, but functionality-wise, this change looks great. I will merge it in once you fix up those minor things. |
|
All your comments were straightforward except this:
I think I figured out what you were asking for, but you should double check my changes. |
|
Good job parsing my poor use of English. I meant "new line" instead of "space." Merging this in! |
call offAuth() with correct method.
closes #471.