Fix: utils.debounce timing corner case. #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invocations of the debounced method between when runNow is scheduled and when it actually runs will schedule additional runNow invocations to be executed in rapid succession.
|
Changes Unknown when pulling 17d5e4b on jamestalmage:fix-debounce-timing-corner-case into * on firebase:master*. |
|
This change looks good to me and I like the added test coverage. @katowulf - I'll leave it for you to merge. I'm not sure I can be of much help testing batch, but maybe Kato can lend some advice. Nice work @jamestalmage! |
|
I'm pondering if we should remove all the batch functionality instead of enhancing it. I think it's fine to merge this for now (thanks, btw!) but if it's stripped out in an upcoming release, understand that it's not a slight to your changes here. |
katowulf
added a commit
that referenced
this pull request
Dec 1, 2014
…case Fix: utils.debounce timing corner case.
|
If you decide to keep batching, then at least merge #490, which would allow users to disable it or implement their own. |
|
I'm totally fine with either choice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invocations of the debounced method between when
runNowis scheduledand when it actually runs will schedule additional
runNowinvocationsto be executed in rapid succession.
Also includes a few clarifications in the comments. A few comments copied from batch didn't make sense in the debounce method. Also, IMO the words
immediateimplies synchronous execution so I changed it tonext tick.I made similar changes to batch (the same problem existed there). I was able to write tests for my changes to debounce, but how to write a similar test for my changes to batch eludes me.