Improves error message for $firebaseAuth initialization and updates migration guide #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwngr
changed the title
|
@AbeHaskins - I made a commit on top of yours with some cleanup. Please bump googlebot and then merge if you're happy with it. I'll resolve merge conflicts in #748 once this gets merged in. |
| | `$authWithCustomToken(token)` | `$signInWithCustomToken(token)` | | | ||
| | `$authWithOAuthPopup(provider[, options])` | `$signInWithPopup(provider)` | `options` can be provided by passing a configured `firebase.database.AuthProvider` instead of a `provider` string | | ||
| | `$authWithOAuthRedirect(provider[, options])` | `$signInWithRedirect(provider)` | `options` can be provided by passing a configured `firebase.database.AuthProvider` instead of a `provider` string | | ||
| | `$authWithOAuthToken(provider, token)` | `$signInWithCredential(credential)` | Tokens must now be transformed into provider specific credentials. This is discussed more in the [Firebase Authentication docs](https://firebase.google.com/docs/auth/#key_functions). | |
There was a problem hiding this comment.
in the Firebase Authentication guide.
|
@AbeHaskins a couple nitpicks. |
| @@ -24,21 +24,36 @@ for details on how to upgrade to the Firebase `3.x.x` SDK. | |||
|
|
|||
| ## `$firebaseAuth` Method Renames / Signature Changes | |||
|
|
|||
| The `$firebaseAuth` service now accepts an optional Firebase `auth` instance instead of a Firebase | |||
There was a problem hiding this comment.
accepts a firebase.auth.Auth instance instead of a firebase.database.Database instance?
There was a problem hiding this comment.
I'd rather use natural language here since firebase.auth.Auth doesn't mean much to anyone since the API doesn't look like that. Maybe we can say firebase.auth() instance though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issues #743 and #749