This repository has been archived by the owner on Aug 25, 2018. It is now read-only.
Install npm and karma-cli on Travis CI #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jpventura
changed the title
jpventura
changed the title
jpventura
force-pushed
the
bug_travis_ci
branch
from
722cdef
to
6aca670
Compare
jpventura
added a commit
to jpventura/backbonefire
that referenced
this pull request
Nov 2, 2016
Update all files that mention BackboneFire reference number to v0.5.1. Requires: googlearchive#156
jpventura
added a commit
to jpventura/backbonefire
that referenced
this pull request
Nov 2, 2016
Update all files that mention BackboneFire reference number to v0.5.1. Requires: googlearchive#156
jpventura
added a commit
to jpventura/backbonefire
that referenced
this pull request
Nov 2, 2016
Updated all package dependencies to its latest version, except Firebase and Backbone. This is an intermediary step before actually upgrading to latest backend version. Removed gulp-server and use gulp-contrib-connect instead (updating Gruntfile.js task also is required to perform the unit tests). We also installed chai and sinon because they are required by karma-chai and karma-sinon respectivelly. Requires: googlearchive#156
jpventura
added a commit
to jpventura/backbonefire
that referenced
this pull request
Nov 2, 2016
Fix Backbone.Firebase.Collection#fetch test to properly check if a collection was successfully synced with Firebase backend. Requires: googlearchive#156
This was referenced Nov 2, 2016
Closed
jpventura
force-pushed
the
bug_travis_ci
branch
3 times, most recently
from
8462402
to
be72713
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Travis CI is falling because it is not finding npm and karma-cli in order to perform the tests (seems like they are not installed on the VMs). We just need configure before_install option at .travis.yml, ensuring that packages are present before starting the unit tests.
Update required in order to Travis CI run the unit tests
Updated all package dependencies to its latest version, except Firebase and Backbone. This is an intermediary step before actually upgrading to latest backend version. Removed gulp-server and use gulp-contrib-connect instead (updating Gruntfile.js task also is required to perform the unit tests). We also installed chai and sinon because they are required by karma-chai and karma-sinon respectivelly.
Fix Backbone.Firebase.Collection#fetch test to properly check if a collection was successfully synced with Firebase backend.
Update all files that mention BackboneFire reference number to v0.5.1.
jpventura
force-pushed
the
bug_travis_ci
branch
from
be72713
to
662c7e8
Compare
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
Travis CI hangs on pull requests that were forcefully updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis CI is falling because it is not finding
npmandkarma-cliin order to perform the tests (seems like they are not installed on the VMs).We just need configure
before_installoption at.travis.yml, ensuring that packages are present before starting the unit tests.Package dependencies were updated to their latest versions, except Firebase and Backbone.
Fix: #157