-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KTX docs from firebaseopensource.com #2363
Conversation
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (2f61c2cc) is created by Prow via merging commits: 843b963 00c8b07. |
Binary Size ReportAffected SDKsNo changes between base commit (843b963) and head commit (2f61c2cc). Test Logs
NotesHead commit (2f61c2cc) is created by Prow via merging commits: 843b963 00c8b07. |
@rlazo can you merge this with your admin rights? I can't imagine that test failure is real. |
/retest |
/test device-check-changed |
1 similar comment
/test device-check-changed |
/test device-check-changed |
3 similar comments
/test device-check-changed |
/test device-check-changed |
/test device-check-changed |
@rlazo is there anything I can do to help with this or are you just using this as a reason to look into flaky tests? |
Hi @samtstern there's nothing pending on your side. I'm looking into the flaky test. Sorry for the delay. |
/test device-check-changed |
@rlazo sgtm and no rush on this! I just feel bad you've had to prod it so many times. |
np! Yeah, not the best that it's taking so long, but that's on us since we have to keep it healthy 😄 |
/test device-check-changed |
@samtstern: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This will remove the sidebar from this page:
https://firebaseopensource.com/projects/firebase/firebase-android-sdk/
Someone else can decide if we actually want to delete all the individual md files listed here:
https://github.com/firebase/firebase-android-sdk/tree/master/docs#kotlin-extensions