Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KTX docs from firebaseopensource.com #2363

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Remove KTX docs from firebaseopensource.com #2363

merged 2 commits into from
Jan 29, 2021

Conversation

samtstern
Copy link
Contributor

This will remove the sidebar from this page:
https://firebaseopensource.com/projects/firebase/firebase-android-sdk/

Someone else can decide if we actually want to delete all the individual md files listed here:
https://github.com/firebase/firebase-android-sdk/tree/master/docs#kotlin-extensions

@google-cla google-cla bot added the cla: yes Override cla label Jan 27, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 27, 2021

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.39% (843b963) to 50.36% (2f61c2cc) by -0.02%.

    Filename Base (843b963) Head (2f61c2cc) Diff
    DoubleNode.java 100.00% 88.24% -11.76%
  • firebase-messaging

    SDK overall coverage changed from 83.43% (843b963) to 83.56% (2f61c2cc) by +0.14%.

    Filename Base (843b963) Head (2f61c2cc) Diff
    TopicsSubscriber.java 89.66% 91.38% +1.72%
  • firebase-storage

    SDK overall coverage changed from 85.48% (843b963) to 85.52% (2f61c2cc) by +0.04%.

    Filename Base (843b963) Head (2f61c2cc) Diff
    UploadTask.java 79.85% 80.22% +0.37%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (2f61c2cc) is created by Prow via merging commits: 843b963 00c8b07.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 27, 2021

Binary Size Report

Affected SDKs

No changes between base commit (843b963) and head commit (2f61c2cc).

Test Logs

Notes

Head commit (2f61c2cc) is created by Prow via merging commits: 843b963 00c8b07.

@samtstern
Copy link
Contributor Author

@rlazo can you merge this with your admin rights? I can't imagine that test failure is real.

@samtstern
Copy link
Contributor Author

/retest

@rlazo
Copy link
Collaborator

rlazo commented Jan 27, 2021

/test device-check-changed

1 similar comment
@rlazo
Copy link
Collaborator

rlazo commented Jan 27, 2021

/test device-check-changed

@rlazo
Copy link
Collaborator

rlazo commented Jan 27, 2021

/test device-check-changed

3 similar comments
@rlazo
Copy link
Collaborator

rlazo commented Jan 27, 2021

/test device-check-changed

@rlazo
Copy link
Collaborator

rlazo commented Jan 28, 2021

/test device-check-changed

@rlazo
Copy link
Collaborator

rlazo commented Jan 28, 2021

/test device-check-changed

@samtstern
Copy link
Contributor Author

@rlazo is there anything I can do to help with this or are you just using this as a reason to look into flaky tests?

@rlazo
Copy link
Collaborator

rlazo commented Jan 29, 2021

Hi @samtstern there's nothing pending on your side. I'm looking into the flaky test. Sorry for the delay.

@rlazo
Copy link
Collaborator

rlazo commented Jan 29, 2021

/test device-check-changed

@samtstern
Copy link
Contributor Author

@rlazo sgtm and no rush on this! I just feel bad you've had to prod it so many times.

@rlazo
Copy link
Collaborator

rlazo commented Jan 29, 2021

@rlazo sgtm and no rush on this! I just feel bad you've had to prod it so many times.

np! Yeah, not the best that it's taking so long, but that's on us since we have to keep it healthy 😄

@rlazo
Copy link
Collaborator

rlazo commented Jan 29, 2021

/test device-check-changed

@google-oss-bot
Copy link
Contributor

@samtstern: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 00c8b07 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo rlazo merged commit c4b4fc7 into master Jan 29, 2021
@rlazo rlazo deleted the samtstern-patch-1 branch January 29, 2021 15:28
@firebase firebase locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants