Update Fdl Code with tests from piper #2749

VinayGuthal · 2021-06-18T16:30:07Z

Move fdl code from piper to github

FolderOrigin-RevId: /google/src/cloud/vguthal/move_stuff/. changes update Hide update update everything update update update

google-cla · 2021-06-18T16:30:21Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2021-06-18T16:30:21Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2021-06-18T16:32:03Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-18T16:32:03Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-oss-bot · 2021-06-18T16:41:03Z

Coverage Report

Affected SDKs

`firebase-dynamic-links`

SDK overall coverage changed from 72.28% (c7d8a80) to 72.58% (e267a94c) by +0.31%.

Filename	Base (`c7d8a80`)	Head (e267a94c)	Diff
DynamicLink.java	77.72%	78.69%	+0.97%
DynamicLinksClient.java	35.71%	33.33%	-2.38%
FirebaseDynamicLinksImpl.java	96.15%	95.24%	-0.92%
FirebaseDynamicLinksImplConstants.java	?	0.00%	?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (e267a94c) is created by Prow via merging commits: c7d8a80 abf6211.

google-oss-bot · 2021-06-18T16:44:58Z

Binary Size Report

Affected SDKs

firebase-dynamic-links

Type Base (c7d8a80) Head (e267a94c) Diff

aar 51.8 kB 53.1 kB +1.32 kB (+2.5%)

apk (aggressive) 307 kB 325 kB +18.6 kB (+6.1%)

apk (release) 936 kB 971 kB +34.7 kB (+3.7%)

Test Logs

Notes

Head commit (e267a94c) is created by Prow via merging commits: c7d8a80 abf6211.

googlebot · 2021-06-18T17:22:49Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-18T17:22:50Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-18T17:25:57Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2021-06-18T17:25:58Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

vkryachko · 2021-06-18T17:28:17Z

firebase-firestore/src/test/java/com/google/firebase/firestore/LoadBundleTaskTest.java

@@ -70,7 +70,7 @@ public void testImplementsAllTaskInterface() {
    }

    for (Method method : Task.class.getDeclaredMethods()) {
-      // This method is annotated with @Hide, skipping.
+      // This method is annotated with , skipping.


Why is firestore part of this PR?

vkryachko · 2021-06-18T17:29:09Z

firebase-messaging/src/main/java/com/google/firebase/messaging/RemoteMessage.java

@@ -140,7 +139,6 @@ public String getTo() {
  }

  /** @hide */
-  @ShowFirstParty


same for fcm, pls undo this change

google-oss-bot · 2021-06-18T19:59:55Z

Macrobenchmark Report

Affected SDKs

Measurements are for head commit (abf6211). Diffing against base commit (c7d8a80) is working in progress.

baseline

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	126.0 ms	158.0 ms	138.0 ms	146.5 ms	156.7 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	38.0 ms	68.0 ms	49.5 ms	64.0 ms	67.2 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	48.0 ms	91.0 ms	68.0 ms	82.1 ms	89.5 ms

firebase-common

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	129.0 ms	168.0 ms	147.0 ms	162.5 ms	167.8 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	37.0 ms	81.0 ms	54.5 ms	62.2 ms	77.8 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	57.0 ms	96.0 ms	75.0 ms	92.1 ms	95.4 ms

firebase-config

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	130.0 ms	167.0 ms	142.5 ms	155.4 ms	165.5 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	40.0 ms	65.0 ms	55.0 ms	60.2 ms	64.4 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	57.0 ms	94.0 ms	76.5 ms	88.1 ms	93.0 ms

firebase-crashlytics

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	140.0 ms	191.0 ms	159.5 ms	171.5 ms	188.1 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	41.0 ms	71.0 ms	52.5 ms	66.1 ms	70.2 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	53.0 ms	88.0 ms	70.5 ms	84.4 ms	88.0 ms

firebase-database

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	118.0 ms	157.0 ms	140.0 ms	151.3 ms	156.4 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	34.0 ms	67.0 ms	48.0 ms	61.4 ms	66.6 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	54.0 ms	87.0 ms	74.5 ms	83.2 ms	86.6 ms

firebase-dynamic-links

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	136.0 ms	175.0 ms	142.5 ms	155.3 ms	171.8 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	32.0 ms	77.0 ms	49.0 ms	61.5 ms	74.9 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	51.0 ms	91.0 ms	76.5 ms	86.5 ms	91.0 ms

firebase-firestore

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	130.0 ms	166.0 ms	149.0 ms	164.0 ms	165.6 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	31.0 ms	72.0 ms	51.5 ms	62.6 ms	71.2 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	63.0 ms	100.0 ms	73.0 ms	88.8 ms	99.2 ms

firebase-functions

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	125.0 ms	164.0 ms	140.5 ms	154.7 ms	163.4 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	38.0 ms	66.0 ms	48.5 ms	58.1 ms	64.7 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	62.0 ms	88.0 ms	72.0 ms	86.0 ms	87.6 ms

firebase-inappmessaging-display

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	161.0 ms	204.0 ms	180.0 ms	199.4 ms	203.8 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	35.0 ms	77.0 ms	52.0 ms	65.4 ms	75.5 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	54.0 ms	89.0 ms	75.0 ms	86.0 ms	88.4 ms

firebase-messaging

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	141.0 ms	174.0 ms	157.0 ms	161.3 ms	172.1 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	46.0 ms	87.0 ms	54.0 ms	64.5 ms	83.6 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	53.0 ms	96.0 ms	73.5 ms	89.2 ms	95.1 ms

firebase-perf

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	142.0 ms	182.0 ms	158.5 ms	174.1 ms	180.7 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	41.0 ms	76.0 ms	55.5 ms	65.1 ms	74.1 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	59.0 ms	89.0 ms	75.5 ms	82.2 ms	88.1 ms

firebase-storage

Name	Device	Min	Max	P50	P90	P99
BenchmarkTest.startup[mode=COLD]	flame-30-en-portrait	132.0 ms	165.0 ms	141.5 ms	155.5 ms	164.0 ms
BenchmarkTest.startup[mode=HOT]	flame-30-en-portrait	39.0 ms	68.0 ms	49.0 ms	60.7 ms	67.8 ms
BenchmarkTest.startup[mode=WARM]	flame-30-en-portrait	50.0 ms	82.0 ms	68.5 ms	79.2 ms	81.8 ms

Test Logs

Head (abf6211): https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/2749/macrobenchmark/1407031535298678789

googlebot · 2021-06-21T13:41:39Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-21T13:41:39Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

vkryachko

LGTM, but let's get a review from the fdl folks

googlebot · 2021-06-21T14:26:38Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-21T14:26:38Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

...ynamic-links/src/main/java/com/google/firebase/dynamiclinks/internal/DynamicLinksClient.java

googlebot · 2021-06-21T17:43:37Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-21T17:43:37Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2021-06-21T17:44:35Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

google-cla · 2021-06-21T17:44:35Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Project import generated by Copybara.

ceed647

FolderOrigin-RevId: /google/src/cloud/vguthal/move_stuff/. changes update Hide update update everything update update update

google-oss-bot added the size/XL label Jun 18, 2021

google-cla bot added the cla: no label Jun 18, 2021

VinayGuthal added cla: yes Override cla and removed cla: no labels Jun 18, 2021

VinayGuthal changed the title ~~Update FDL code from Piper~~ Update Fdl Code with tests from piper Jun 18, 2021

VinayGuthal requested review from eldhosembabu and vkryachko June 18, 2021 17:19

googlebot added cla: no and removed cla: yes Override cla labels Jun 18, 2021

VinayGuthal force-pushed the new_b branch from 90ced75 to ceed647 Compare June 18, 2021 17:23

update

5aa442e

VinayGuthal added cla: yes Override cla and removed cla: no labels Jun 18, 2021

vkryachko reviewed Jun 18, 2021

View reviewed changes

VinayGuthal added 3 commits June 21, 2021 19:09

update

ad489a4

update

2e6e18a

Merge branch 'master' into new_b

a236918

google-cla bot added cla: no and removed cla: yes Override cla labels Jun 21, 2021

update

3958f87

vkryachko reviewed Jun 21, 2021

View reviewed changes

VinayGuthal added cla: yes Override cla and removed cla: no labels Jun 21, 2021

eldhosembabu reviewed Jun 21, 2021

View reviewed changes

...ynamic-links/src/main/java/com/google/firebase/dynamiclinks/internal/DynamicLinksClient.java Outdated Show resolved Hide resolved

eldhosembabu reviewed Jun 21, 2021

View reviewed changes

...ynamic-links/src/main/java/com/google/firebase/dynamiclinks/internal/DynamicLinksClient.java Outdated Show resolved Hide resolved

eldhosembabu approved these changes Jun 21, 2021

View reviewed changes

VinayGuthal added 2 commits June 21, 2021 23:11

update

300b0a0

update

abf6211

google-cla bot added cla: no and removed cla: yes Override cla labels Jun 21, 2021

VinayGuthal added cla: yes Override cla and removed cla: no labels Jun 21, 2021

googlebot added cla: no and removed cla: yes Override cla labels Jun 21, 2021

google-cla bot added cla: yes Override cla and removed cla: no labels Jun 21, 2021

VinayGuthal merged commit 91681dd into master Jun 21, 2021

VinayGuthal deleted the new_b branch June 21, 2021 17:55

firebase locked and limited conversation to collaborators Jul 22, 2021

Update Fdl Code with tests from piper #2749

Update Fdl Code with tests from piper #2749

Conversation

VinayGuthal commented Jun 18, 2021 • edited Loading

google-cla bot commented Jun 18, 2021

googlebot commented Jun 18, 2021

googlebot commented Jun 18, 2021

google-cla bot commented Jun 18, 2021

google-oss-bot commented Jun 18, 2021 • edited Loading

Coverage Report

Affected SDKs

firebase-dynamic-links

Test Logs

Notes

google-oss-bot commented Jun 18, 2021 • edited Loading

Binary Size Report

Affected SDKs

firebase-dynamic-links

Test Logs

Notes

googlebot commented Jun 18, 2021

google-cla bot commented Jun 18, 2021

google-cla bot commented Jun 18, 2021

googlebot commented Jun 18, 2021

vkryachko Jun 18, 2021

Choose a reason for hiding this comment

vkryachko Jun 18, 2021

Choose a reason for hiding this comment

google-oss-bot commented Jun 18, 2021 • edited Loading

Macrobenchmark Report

Affected SDKs

baseline

firebase-common

firebase-config

firebase-crashlytics

firebase-database

firebase-dynamic-links

firebase-firestore

firebase-functions

firebase-inappmessaging-display

firebase-messaging

firebase-perf

firebase-storage

Test Logs

googlebot commented Jun 21, 2021

google-cla bot commented Jun 21, 2021

vkryachko left a comment

Choose a reason for hiding this comment

googlebot commented Jun 21, 2021

google-cla bot commented Jun 21, 2021

googlebot commented Jun 21, 2021

google-cla bot commented Jun 21, 2021

googlebot commented Jun 21, 2021

google-cla bot commented Jun 21, 2021

VinayGuthal commented Jun 18, 2021 •

edited

Loading

google-oss-bot commented Jun 18, 2021 •

edited

Loading

`firebase-dynamic-links`

google-oss-bot commented Jun 18, 2021 •

edited

Loading

`firebase-dynamic-links`

google-oss-bot commented Jun 18, 2021 •

edited

Loading