Add collection of ANRs to Crashlytics #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n instead of Report. (#2668)
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (133e2b76) is created by Prow via merging commits: 91681dd 3ebad98. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (133e2b76) is created by Prow via merging commits: 91681dd 3ebad98. |
tejasd
commented
Jun 24, 2021
| @@ -74,7 +78,8 @@ dependencies { | |||
| annotationProcessor 'com.google.auto.value:auto-value:1.6.5' | |||
|
|
|||
| testImplementation 'androidx.test:runner:1.3.0' | |||
| testImplementation "org.robolectric:robolectric:$robolectricVersion" | |||
There was a problem hiding this comment.
Consider updating $robolectricVersion
tejasd
commented
Jun 24, 2021
| @@ -47,6 +47,12 @@ public String eventToJson(@NonNull CrashlyticsReport.Session.Event event) { | |||
| return CRASHLYTICS_REPORT_JSON_ENCODER.encode(event); | |||
| } | |||
|
|
|||
| @NonNull | |||
| public String appExitInfoToJson( | |||
There was a problem hiding this comment.
Rename to applicationExitInfoToJson
tejasd
commented
Jun 24, 2021
| ActivityManager activityManager = | ||
| (ActivityManager) context.getSystemService(Context.ACTIVITY_SERVICE); | ||
| List<ApplicationExitInfo> applicationExitInfoList = | ||
| activityManager.getHistoricalProcessExitReasons(null, 0, 0); |
There was a problem hiding this comment.
Change maxEvents to 1, and add a TODO to change this later if start linking ApplicationExitInfo to other events.
tejasd
commented
Jun 24, 2021
| UserMetadata userMetadataForSession) { | ||
| long sessionStartTime = reportPersistence.getStartTimestampMillis(sessionId); | ||
| // ApplicationExitInfo did not occur during the session. | ||
| if (applicationExitInfo.getTimestamp() < sessionStartTime) { |
There was a problem hiding this comment.
This might cause a bug where an ANR is sent repeatedly.
There was a problem hiding this comment.
Does not cause a bug.
tejasd
commented
Jun 24, 2021
|
|
||
| /** If an ApplicationExitInfo exists relevant to the session, writes that event. */ | ||
| private void writeApplicationExitInfoEventIfRelevant(String sessionId) { | ||
| if (android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { |
There was a problem hiding this comment.
Add log when it's not API 30
|
@tejasd: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
mrichards
approved these changes
Jun 24, 2021
Macrobenchmark ReportAffected SDKsMeasurements are for head commit (3ebad98). Diffing against base commit (91681dd) is working in progress.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getHistoricalProcessExitReasonsto collect ANR data