-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Doclava with Dackka #4324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report 1Affected Products
Test Logs |
vkryachko
approved these changes
Nov 15, 2022
rlazo
approved these changes
Nov 15, 2022
davidmotson
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Remove restriction on Dackka's Javadoc * Refactor release plugin to use dackka
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/255992607, this replaces our old Javadoc generation through Doclava with our new implementation with Dackka- so that our release process now generates Javadocs through the
DackkaPlugin
.For the sake of brevity (and ensuring everything works), this does not change any task names or even the general format of our release plugins. Especially since some of these plugins are very inter-tangled. This will be addressed in a future PR (probably in relation with my
firebase-library
refactor work coming up).