Tomandersen/handshake rewrite #6015
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [b/338407806](https://b.corp.google.com/issues/338407806), This fixes the issues with the health metrics action failing. It seemed to stem from a bunch of outdated dependencies in the health metrics sub projects.
… tomandersen/watchHandshake # Conflicts: # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteStore.java
…andersen/watchHandshake # Conflicts: # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteStore.java
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/FirebaseFirestore.html 2024-06-19 16:44:01.222773203 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/FirebaseFirestore.html 2024-06-19 16:41:29.828085746 +0000
@@ -167,7 +167,7 @@
</td>
</tr>
<tr>
- <td><code>synchronized @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/firestore/PersistentCacheIndexManager.html">PersistentCacheIndexManager</a></code></td>
+ <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/firestore/PersistentCacheIndexManager.html">PersistentCacheIndexManager</a></code></td>
<td>
<div><code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#getPersistentCacheIndexManager()">getPersistentCacheIndexManager</a>()</code></div>
<p>Gets the <code>PersistentCacheIndexManager</code> instance used by this <code>FirebaseFirestore</code> object.</p>
@@ -790,7 +790,7 @@
</div>
<div class="api-item"><a name="getPersistentCacheIndexManager--"></a><a name="getpersistentcacheindexmanager"></a>
<h3 class="api-name" id="getPersistentCacheIndexManager()">getPersistentCacheIndexManager</h3>
- <pre class="api-signature no-pretty-print">synchronized public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/firestore/PersistentCacheIndexManager.html">PersistentCacheIndexManager</a> <a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#getPersistentCacheIndexManager()">getPersistentCacheIndexManager</a>()</pre>
+ <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/firestore/PersistentCacheIndexManager.html">PersistentCacheIndexManager</a> <a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#getPersistentCacheIndexManager()">getPersistentCacheIndexManager</a>()</pre>
<p>Gets the <code>PersistentCacheIndexManager</code> instance used by this <code>FirebaseFirestore</code> object. </p>
<p>This is not the same as Cloud Firestore Indexes. Persistent cache indexes are optional indexes that only exist within the SDK to assist in local query execution.</p>
<div class="devsite-table-wrapper"> |
tom-andersen
changed the base branch from
tomandersen/dbToken
to
tomandersen/streamRefactor
…to tomandersen/handshakeRewrite
… tomandersen/handshakeRewrite # Conflicts: # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/WatchStream.java # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/WriteStream.java
Size Report 1Affected Products
Test Logs |
tom-andersen
changed the base branch from
tomandersen/streamRefactor
to
tomandersen/componentProviderRefactor
…actor' into tomandersen/handshakeRewrite # Conflicts: # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/AccessHelper.java # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/remote/RemoteStoreTest.java # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/testutil/IntegrationTestUtil.java # firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java # firebase-firestore/src/main/java/com/google/firebase/firestore/core/FirestoreClient.java # firebase-firestore/src/main/java/com/google/firebase/firestore/core/MemoryComponentProvider.java # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/FirestoreChannel.java # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteComponenetProvider.java # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/RemoteStore.java # firebase-firestore/src/main/java/com/google/firebase/firestore/remote/WriteStream.java # firebase-firestore/src/test/java/com/google/firebase/firestore/spec/MemorySpecTest.java # firebase-firestore/src/test/java/com/google/firebase/firestore/spec/SQLiteSpecTest.java # firebase-firestore/src/test/java/com/google/firebase/firestore/spec/SpecTestCase.java
…/handshakeRewrite
…tomandersen/handshakeRewrite # Conflicts: # firebase-firestore/src/test/java/com/google/firebase/firestore/integration/AsyncTaskAccumulator.java # firebase-firestore/src/test/java/com/google/firebase/firestore/integration/FirebaseFirestoreTest.java
tom-andersen
changed the base branch from
tomandersen/componentProviderRefactor
to
tomandersen/handshakeTest
…der' into tomandersen/handshakeRewrite # Conflicts: # firebase-firestore/src/androidTest/java/com/google/firebase/firestore/ValidationTest.java # firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java # firebase-firestore/src/main/java/com/google/firebase/firestore/FirestoreClientProvider.java # firebase-firestore/src/main/java/com/google/firebase/firestore/core/FirestoreClient.java # firebase-firestore/src/test/java/com/google/firebase/firestore/FirebaseFirestoreIntegrationTestFactory.java
tom-andersen
changed the base branch from
tomandersen/handshakeTest
to
tomandersen/firestoreClientProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.