Skip to content

Fix health metrics failures #5969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 17, 2024
Merged

Fix health metrics failures #5969

merged 7 commits into from
May 17, 2024

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented May 15, 2024

Per b/338407806,

This fixes the issues with the health metrics action failing. It seemed to stem from a bunch of outdated dependencies in the health metrics sub projects.

@daymxn daymxn self-assigned this May 15, 2024
@daymxn daymxn changed the title Fix health metrics failures [WIP] Fix health metrics failures May 15, 2024
Copy link
Contributor

github-actions bot commented May 15, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 15, 2024

Size Report 1

Affected Products

  • base

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-abt

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?141 kB? (?)
    apk (release)?4.41 MB? (?)
  • firebase-annotations

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?12.0 kB? (?)
  • firebase-appcheck

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?390 kB? (?)
    apk (release)?4.88 MB? (?)
  • firebase-appcheck-debug

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?396 kB? (?)
    apk (release)?4.89 MB? (?)
  • firebase-appcheck-debug-testing

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?421 kB? (?)
    apk (release)?5.05 MB? (?)
  • firebase-appcheck-interop

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?316 kB? (?)
    apk (release)?1.84 MB? (?)
  • firebase-appcheck-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?390 kB? (?)
    apk (release)?4.88 MB? (?)
  • firebase-appcheck-playintegrity

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?405 kB? (?)
    apk (release)?4.93 MB? (?)
  • firebase-appdistribution

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?1.08 MB? (?)
    apk (release)?7.01 MB? (?)
  • firebase-appdistribution-api

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?145 kB? (?)
    apk (release)?4.42 MB? (?)
  • firebase-appdistribution-api-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?145 kB? (?)
    apk (release)?4.42 MB? (?)
  • firebase-common

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?140 kB? (?)
    apk (release)?4.40 MB? (?)
  • firebase-common-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?141 kB? (?)
    apk (release)?4.40 MB? (?)
  • firebase-components

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?20.8 kB? (?)
    apk (release)?2.06 MB? (?)
  • firebase-config

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?211 kB? (?)
    apk (release)?4.58 MB? (?)
  • firebase-config-interop

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?20.8 kB? (?)
    apk (release)?2.02 MB? (?)
  • firebase-config-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?211 kB? (?)
    apk (release)?4.58 MB? (?)
  • firebase-crashlytics

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?688 kB? (?)
    apk (release)?5.84 MB? (?)
  • firebase-crashlytics-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?688 kB? (?)
    apk (release)?5.84 MB? (?)
  • firebase-crashlytics-ndk

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive / arm64-v8a)?1.86 MB? (?)
    apk (aggressive / armeabi-v7a)?1.34 MB? (?)
    apk (aggressive / x86)?1.84 MB? (?)
    apk (aggressive / x86_64)?1.90 MB? (?)
    apk (release / arm64-v8a)?7.01 MB? (?)
    apk (release / armeabi-v7a)?6.48 MB? (?)
    apk (release / x86)?6.98 MB? (?)
    apk (release / x86_64)?7.05 MB? (?)
  • firebase-database

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?390 kB? (?)
    apk (release)?5.29 MB? (?)
  • firebase-database-collection

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?318 kB? (?)
    apk (release)?1.86 MB? (?)
  • firebase-database-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?391 kB? (?)
    apk (release)?5.29 MB? (?)
  • firebase-datatransport

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?226 kB? (?)
    apk (release)?4.62 MB? (?)
  • firebase-decoders-json

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?9.38 kB? (?)
    apk (release)?26.5 kB? (?)
  • firebase-dynamic-links

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?387 kB? (?)
    apk (release)?4.89 MB? (?)
  • firebase-dynamic-links-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?391 kB? (?)
    apk (release)?4.89 MB? (?)
  • firebase-dynamic-module-support

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?157 kB? (?)
    apk (release)?4.52 MB? (?)
  • firebase-encoders

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?9.38 kB? (?)
    apk (release)?27.2 kB? (?)
  • firebase-encoders-json

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?20.8 kB? (?)
    apk (release)?2.01 MB? (?)
  • firebase-encoders-proto

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?9.56 kB? (?)
    apk (release)?40.5 kB? (?)
  • firebase-encoders-reflective

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?9.75 kB? (?)
    apk (release)?42.6 kB? (?)
  • firebase-firestore

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?554 kB? (?)
    apk (release)?11.1 MB? (?)
  • firebase-firestore-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?554 kB? (?)
    apk (release)?11.1 MB? (?)
  • firebase-functions

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?439 kB? (?)
    apk (release)?5.43 MB? (?)
  • firebase-functions-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?439 kB? (?)
    apk (release)?5.43 MB? (?)
  • firebase-inappmessaging

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?1.04 MB? (?)
    apk (release)?11.5 MB? (?)
  • firebase-inappmessaging-display

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?2.01 MB? (?)
    apk (release)?13.8 MB? (?)
  • firebase-inappmessaging-display-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?2.01 MB? (?)
    apk (release)?13.8 MB? (?)
  • firebase-inappmessaging-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?1.04 MB? (?)
    apk (release)?11.5 MB? (?)
  • firebase-installations

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?148 kB? (?)
    apk (release)?4.46 MB? (?)
  • firebase-installations-interop

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?73.1 kB? (?)
    apk (release)?1.40 MB? (?)
  • firebase-installations-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?148 kB? (?)
    apk (release)?4.46 MB? (?)
  • firebase-messaging

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?578 kB? (?)
    apk (release)?5.30 MB? (?)
  • firebase-messaging-directboot

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?578 kB? (?)
    apk (release)?5.30 MB? (?)
  • firebase-messaging-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?578 kB? (?)
    apk (release)?5.31 MB? (?)
  • firebase-ml-modeldownloader

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?235 kB? (?)
    apk (release)?4.78 MB? (?)
  • firebase-ml-modeldownloader-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?235 kB? (?)
    apk (release)?4.78 MB? (?)
  • firebase-perf

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?1.57 MB? (?)
    apk (release)?9.06 MB? (?)
  • firebase-perf-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?1.57 MB? (?)
    apk (release)?9.06 MB? (?)
  • firebase-sessions

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?556 kB? (?)
    apk (release)?5.53 MB? (?)
  • firebase-storage

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?399 kB? (?)
    apk (release)?4.99 MB? (?)
  • firebase-storage-ktx

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?399 kB? (?)
    apk (release)?4.99 MB? (?)
  • firebase-vertexai

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?1.29 MB? (?)
    apk (release)?9.27 MB? (?)
  • protolite-well-known-types

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)
  • transport-api

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?9.38 kB? (?)
    apk (release)?31.4 kB? (?)
  • transport-backend-cct

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?97.8 kB? (?)
    apk (release)?258 kB? (?)
  • transport-runtime

    TypeBase (a7a497f)Merge (10c7286)Diff
    apk (aggressive)?55.7 kB? (?)
    apk (release)?193 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2lgN49DqpU.html

Copy link
Contributor

github-actions bot commented May 15, 2024

Unit Test Results

     944 files  ±0       944 suites  ±0   33m 42s ⏱️ - 1m 11s
  5 205 tests ±0    5 184 ✔️ ±0  21 💤 ±0  0 ±0 
10 495 runs  ±0  10 453 ✔️ ±0  42 💤 ±0  0 ±0 

Results for commit d956e09. ± Comparison against base commit a7a497f.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 15, 2024

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.76% (a7a497f) to 44.77% (10c7286) by +0.02%.

    FilenameBase (a7a497f)Merge (10c7286)Diff
    LruGarbageCollector.java93.64%97.27%+3.64%
  • firebase-installations

    Overall coverage changed from ? (a7a497f) to 58.68% (10c7286) by ?.

    23 individual files with coverage change

    FilenameBase (a7a497f)Merge (10c7286)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    Installations.kt?40.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-storage

    Overall coverage changed from 83.92% (a7a497f) to 83.96% (10c7286) by +0.04%.

    FilenameBase (a7a497f)Merge (10c7286)Diff
    StreamDownloadTask.java88.41%88.89%+0.48%
  • firebase-messaging

    FilenameBase (a7a497f)Merge (10c7286)Diff
    FirebaseMessaging.java76.40%77.20%+0.80%
    RequestDeduplicator.java90.00%80.00%-10.00%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Yetb7Zoe5j.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 15, 2024

Startup Time Report 1

The report is too large (122,622 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PgqgdITiRn/index.html

@daymxn daymxn changed the title [WIP] Fix health metrics failures Fix health metrics failures May 16, 2024
@daymxn daymxn requested a review from rlazo May 16, 2024 18:22
@rlazo rlazo merged commit 188cdb1 into master May 17, 2024
@rlazo rlazo deleted the daymon-fix-health-metrics-failure branch May 17, 2024 04:54
tom-andersen pushed a commit that referenced this pull request May 22, 2024
Per [b/338407806](https://b.corp.google.com/issues/338407806),

This fixes the issues with the health metrics action failing. It seemed
to stem from a bunch of outdated dependencies in the health metrics sub
projects.
@firebase firebase locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants