Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types for AlertPayloads #1087

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Update types for AlertPayloads #1087

merged 3 commits into from
Apr 29, 2022

Commits on Apr 29, 2022

  1. Update types for AlertPayloads 

    This commit updates the typing for the AlertPayloads.

There was a discrepency between the type definitions and what
prod was returning.

From:
com.google.firebase.firebasealerts.*

To
type.googleapis.com/google.events.firebase.firebasealerts.v1.*
    @TheIronDev
    TheIronDev committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    1678f4b View commit details
    Browse the repository at this point in the history

  2. Quickly patch some of these types

    @TheIronDev
    TheIronDev committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    9f4299b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into tystark.fixAlertTypes

    @taeold
    taeold committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    10f6238 View commit details
    Browse the repository at this point in the history