Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types for AlertPayloads #1087

Merged
merged 3 commits into from
Apr 29, 2022

Conversation

TheIronDev
Copy link
Contributor

This commit updates the typing for the AlertPayloads.

There was a discrepency between the type definitions and what
prod was returning.

From:
com.google.firebase.firebasealerts.*

To
type.googleapis.com/google.events.firebase.firebasealerts.v1.*

This commit updates the typing for the AlertPayloads.

There was a discrepency between the type definitions and what
prod was returning.

From:
com.google.firebase.firebasealerts.*

To
type.googleapis.com/google.events.firebase.firebasealerts.v1.*
@TheIronDev TheIronDev merged commit c4f63c7 into firebase:master Apr 29, 2022
@inlined
Copy link
Member

inlined commented Apr 29, 2022

What a win to find these before our customers do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants