Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types for AlertPayloads #1087

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Update types for AlertPayloads #1087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1678f4b
Update types for AlertPayloads
TheIronDev Apr 29, 2022
9f4299b
Quickly patch some of these types
TheIronDev Apr 29, 2022
10f6238
Merge branch 'master' into tystark.fixAlertTypes
taeold Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/v2/providers/alerts/billing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import * as options from '../../options';
* Payload is wrapped inside a FirebaseAlertData object.
*/
export interface PlanUpdatePayload {
['@type']: 'com.google.firebase.firebasealerts.PlanUpdatePayload';
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.BillingPlanUpdatePayload';
billingPlan: string;
principalEmail: string;
}
Expand All @@ -17,7 +17,7 @@ export interface PlanUpdatePayload {
* Payload is wrapped inside a FirebaseAlertData object.
*/
export interface PlanAutomatedUpdatePayload {
['@type']: 'com.google.firebase.firebasealerts.PlanAutomatedUpdatePayload';
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.BillingPlanAutomatedUpdatePayload';
billingPlan: string;
}

Expand Down
12 changes: 6 additions & 6 deletions src/v2/providers/alerts/crashlytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ interface Issue {
* Payload is wrapped inside a FirebaseAlertData object.
*/
export interface NewFatalIssuePayload {
['@type']: 'com.google.firebase.firebasealerts.CrashlyticsNewFatalIssuePayload';
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsNewFatalIssuePayload';
issue: Issue;
}

Expand All @@ -24,7 +24,7 @@ export interface NewFatalIssuePayload {
* Payload is wrapped inside a FirebaseAlertData object.
*/
export interface NewNonfatalIssuePayload {
['@type']: 'com.google.firebase.firebasealerts.CrashlyticsNewNonfatalIssuePayload';
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsNewNonfatalIssuePayload';
issue: Issue;
}

Expand All @@ -33,7 +33,7 @@ export interface NewNonfatalIssuePayload {
* Payload is wrapped inside a FirebaseAlertData object.
*/
export interface RegressionAlertPayload {
['@type']: 'com.google.firebase.firebasealerts.CrashlyticsRegressionAlertPayload';
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsRegressionAlertPayload';
type: string;
issue: Issue;
resolveTime: string;
Expand All @@ -52,7 +52,7 @@ interface TrendingIssueDetails {
* Payload is wrapped inside a FirebaseAlertData object.
*/
export interface StabilityDigestPayload {
['@type']: 'com.google.firebase.firebasealerts.CrashlyticsStabilityDigestPayload';
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsStabilityDigestPayload';
digestDate: string;
trendingIssues: TrendingIssueDetails[];
}
Expand All @@ -62,7 +62,7 @@ export interface StabilityDigestPayload {
* Payload is wrapped inside a FirebaseAlertData object.
*/
export interface VelocityAlertPayload {
['@type']: 'com.google.firebase.firebasealerts.VelocityAlertPayload';
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsVelocityAlertPayload';
issue: Issue;
createTime: string;
crashCount: number;
Expand All @@ -75,7 +75,7 @@ export interface VelocityAlertPayload {
* Payload is wrapped inside a FirebaseAlertData object.
*/
export interface NewAnrIssuePayload {
['@type']: 'com.google.firebase.firebasealerts.NewAnrIssuePayload';
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsNewAnrIssuePayload';
issue: Issue;
}

Expand Down