Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in account linking flows #8196

Merged
merged 5 commits into from
Jun 14, 2021
Merged

Bug fix in account linking flows #8196

merged 5 commits into from
Jun 14, 2021

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Jun 4, 2021

Bug fix for an issue where after linking an account with email link, Game Center, or phone auth, the ID token still shows the previous provider (i.e. anonymous), even after force refresh.

[Googler-only internal tracking bug: b/189258684]

@google-oss-bot
Copy link

google-oss-bot commented Jun 4, 2021

Coverage Report

Affected SDKs

  • FirebaseAuth-iOS-FirebaseAuth.framework

    SDK overall coverage changed from 68.79% (5aaf38c) to 68.69% (1fc215a) by -0.10%.

    Filename Base (5aaf38c) Head (1fc215a) Diff
    FIRUser.m 69.33% 68.88% -0.45%

Test Logs

@rosalyntan rosalyntan changed the title Bug fix in link with email link flow Bug fix in account linking flows Jun 5, 2021
@rosalyntan rosalyntan marked this pull request as ready for review June 5, 2021 02:53
@rosalyntan rosalyntan requested a review from paulb777 June 5, 2021 02:57
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix relate to #6521

FirebaseAuth/CHANGELOG.md Outdated Show resolved Hide resolved
@rosalyntan
Copy link
Member Author

Does this fix relate to #6521

No, I don't believe the issues are related -- in the other issue, the problem is that the ID token and the approximate expiration time are getting out of sync. In this issue, neither the ID token nor the approximate expiration time were being updated properly, and only in account linking flows.

@rosalyntan rosalyntan merged commit cb0bde5 into master Jun 14, 2021
@rosalyntan rosalyntan deleted the rosalyntan.link branch June 14, 2021 22:29
@firebase firebase locked and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants