[Release] Re-spin FST with signed artifact #12549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I don't think there is an issue but making a note here... This is the build log that seems to confirm it is picking up a signature. Unfortunately, I cannot double click into the "Show Signature Information" part. Xcode 15.3 RC doesn't do anything when you double click that. But, I manually dragged in the xcframework and you can see the signature pick up: |
|
Pointing to this branch, I built my test app for iOS and also for macOS. Both archives validated successfully. This is gtg on green. |
|
@paulb777, despite the failing CI, think this can still merge. WDYT? I've never seen these failures before but they are mainly FirebasweFunctions integration tests. |
|
SGTM - I would think any signing issues would show up at build time - not runtime. |
|
I'll merge and retag now. |
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Apr 9, 2024
….23.1" (#948) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [firebase/firebase-ios-sdk](https://togithub.com/firebase/firebase-ios-sdk) | minor | `from: "10.21.0"` -> `from: "10.23.1"` | --- ### Release Notes <details> <summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary> ### [`v10.23.1`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.23.1) [Compare Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.23.0...10.23.1) The Firebase Apple SDK (10.23.1) is now available. This release is only available for CocoaPods and Swift Package Manager and only changes Firebase Analytics. See details at [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#10.23.1) #### What's Changed - \[Release] Update Package.swift for 10.23.1 patch by [@​ncooke3](https://togithub.com/ncooke3) in [firebase/firebase-ios-sdk#12644 - Analytics 10.23.1 by [@​htcgh](https://togithub.com/htcgh) in [firebase/firebase-ios-sdk#12648 - 10.23.1 podspec updates by [@​paulb777](https://togithub.com/paulb777) in [firebase/firebase-ios-sdk#12647 - Tweak release note by [@​paulb777](https://togithub.com/paulb777) in [firebase/firebase-ios-sdk#12649 **Full Changelog**: firebase/firebase-ios-sdk@10.23.0...10.23.1 ### [`v10.23.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.23.0) [Compare Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.22.1...10.23.0) The Firebase Apple SDK (10.23.0) is now available. For more details, see the [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#10.23.0) To install this SDK, see [Add Firebase to your project.](https://firebase.google.com/docs/ios/setup) #### What's Changed - \[Release] Update versions for Release 10.23.0 by [@​andrewheard](https://togithub.com/andrewheard) in [firebase/firebase-ios-sdk#12467 - Add API tests for hashed email and phone number by [@​tsunghung](https://togithub.com/tsunghung) in [firebase/firebase-ios-sdk#12469 - Update upload-symbols to 13.7 by [@​themiswang](https://togithub.com/themiswang) in [firebase/firebase-ios-sdk#12471 - Analytics 10.22.1 by [@​tsunghung](https://togithub.com/tsunghung) in [firebase/firebase-ios-sdk#12482 - Upgrade `clang-format` to v18 by [@​andrewheard](https://togithub.com/andrewheard) in [firebase/firebase-ios-sdk#12483 - \[Release] Add patch note for 10.22.1 by [@​ncooke3](https://togithub.com/ncooke3) in [firebase/firebase-ios-sdk#12490 - Restore 10.23.0 versions to main after 10.22.1 by [@​paulb777](https://togithub.com/paulb777) in [firebase/firebase-ios-sdk#12497 - Patch abseil-cpp to ignore deprecated errors in new Xcode. by [@​jonsimantov](https://togithub.com/jonsimantov) in [firebase/firebase-ios-sdk#12498 - Fix CI breakage from recent merge by [@​paulb777](https://togithub.com/paulb777) in [firebase/firebase-ios-sdk#12504 - Resolved warning no rule to process file 'PrivacyInfo.xcprivacy' of type 'text.xml' with CocoaPods by [@​HikaruSato](https://togithub.com/HikaruSato) in [firebase/firebase-ios-sdk#12513 - Upgrade grpc to 1.62 for cocoapods by [@​wu-hui](https://togithub.com/wu-hui) in [firebase/firebase-ios-sdk#12398 - Snapshot listener source from cache by [@​milaGGL](https://togithub.com/milaGGL) in [firebase/firebase-ios-sdk#12370 - \[Rollouts] Feature rollouts merge to main by [@​themiswang](https://togithub.com/themiswang) in [firebase/firebase-ios-sdk#12410 - \[spm] Update grpc to 1.62.3 by [@​paulb777](https://togithub.com/paulb777) in [firebase/firebase-ios-sdk#12520 - \[Release Tooling] Copy over macOS/macCatalyst plists by [@​ncooke3](https://togithub.com/ncooke3) in [firebase/firebase-ios-sdk#12517 - NOTICES Change by [@​github-actions](https://togithub.com/github-actions) in [firebase/firebase-ios-sdk#12524 - Changelog updates for 10.23.0 by [@​paulb777](https://togithub.com/paulb777) in [firebase/firebase-ios-sdk#12533 - \[Firestore] Improve logging in scripts/check_firestore_symbols.sh by [@​ncooke3](https://togithub.com/ncooke3) in [firebase/firebase-ios-sdk#12535 - \[Firestore] Add unlinked symbol introduced in [#​12370](https://togithub.com/firebase/firebase-ios-sdk/issues/12370) by [@​ncooke3](https://togithub.com/ncooke3) in [firebase/firebase-ios-sdk#12534 - \[Firestore] Re-export public header added in [#​12370](https://togithub.com/firebase/firebase-ios-sdk/issues/12370) by [@​ncooke3](https://togithub.com/ncooke3) in [firebase/firebase-ios-sdk#12537 - \[Firestore] Bump dependency ranges for Firestore's binary SPM distro by [@​ncooke3](https://togithub.com/ncooke3) in [firebase/firebase-ios-sdk#12538 - Fix Firestore build warnings by [@​cherylEnkidu](https://togithub.com/cherylEnkidu) in [firebase/firebase-ios-sdk#12536 - Analytics 10.23.0 by [@​htcgh](https://togithub.com/htcgh) in [firebase/firebase-ios-sdk#12539 - \[Release] Update FirebaseFirestoreInternal checksum by [@​ncooke3](https://togithub.com/ncooke3) in [firebase/firebase-ios-sdk#12545 - \[Release] Re-spin FST with signed artifact by [@​ncooke3](https://togithub.com/ncooke3) in [firebase/firebase-ios-sdk#12549 #### New Contributors - [@​HikaruSato](https://togithub.com/HikaruSato) made their first contribution in [firebase/firebase-ios-sdk#12513 **Full Changelog**: firebase/firebase-ios-sdk@10.22.1...10.23.0 ### [`v10.22.1`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.22.1): Firebase Apple 10.22.1 [Compare Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.22.0...10.22.1) The Firebase Apple SDK (10.22.1) is now available. For more details, see the [Firebase Apple SDK release notes.](https://firebase.google.com/support/release-notes/ios#10.22.1) To install this SDK, see [Add Firebase to your project.](https://firebase.google.com/docs/ios/setup) ### [`v10.22.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.22.0): Firebase Apple 10.22.0 [Compare Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.21.0...10.22.0) The Firebase Apple SDK (10.22.0) is now available. For more details, see the [Firebase Apple SDK release notes](https://firebase.google.com/support/release-notes/ios#10.22.0). To install this SDK, see [Add Firebase to your project](https://firebase.google.com/docs/ios/setup). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog