Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make missing analytics a warning instead of error #1653

Merged
merged 4 commits into from
Aug 9, 2018
Merged

Make missing analytics a warning instead of error #1653

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef12434
Make missing analytics a warning instead of error
paulb777 Aug 8, 2018
02daf75
Improve missing Analytics message
paulb777 Aug 8, 2018
8dbf782
style
paulb777 Aug 8, 2018
3bbf63b
Use up to 100 characters
paulb777 Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Firebase/Core/FIRApp.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,10 @@ - (BOOL)configureCore {
if ([self.name isEqualToString:kFIRDefaultAppName]) {
Class firAnalyticsClass = NSClassFromString(@"FIRAnalytics");
if (!firAnalyticsClass) {
FIRLogError(kFIRLoggerCore, @"I-COR000022", @"Firebase Analytics is not available.");
FIRLogWarning(kFIRLoggerCore, @"I-COR000022",
@"Firebase Analytics is not available. To add "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please fill all the width of the columns (should be 100 char/column).

@"it, include Firebase/Core in the Podfile or add "
@"FirebaseAnalytics.framework to the Link Build Phase");
} else {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wundeclared-selector"
Expand Down