Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear pending timeout after promise.race #5701

Merged
merged 4 commits into from
Nov 10, 2021
Merged

clear pending timeout after promise.race #5701

merged 4 commits into from
Nov 10, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Nov 4, 2021

Fixes #5692

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2021

🦋 Changeset detected

Latest commit: ac24ef8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/functions Patch
firebase Patch
@firebase/functions-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 4, 2021

Binary Size Report

Affected SDKs

  • @firebase/functions

    Type Base (dbd54f7) Head (60a752b) Diff
    browser 8.85 kB 8.99 kB +145 B (+1.6%)
    esm5 10.9 kB 11.1 kB +161 B (+1.5%)
    main 11.7 kB 11.8 kB +161 B (+1.4%)
    module 8.85 kB 8.99 kB +145 B (+1.6%)
  • firebase

    Type Base (dbd54f7) Head (60a752b) Diff
    firebase-compat.js 749 kB 749 kB +83 B (+0.0%)
    firebase-functions-compat.js 7.86 kB 7.95 kB +83 B (+1.1%)
    firebase-functions.js 30.4 kB 30.9 kB +504 B (+1.7%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 4, 2021

Size Analysis Report

Affected Products

  • @firebase/functions

    • httpsCallable

      Size Table

      TypeBase (dbd54f7)Head (7955095)Diff
      size
      5.89 kB
      5.98 kB
      +87 B (+1.5%)
      size-with-ext-deps
      11.8 kB
      11.9 kB
      +87 B (+0.7%)

packages/functions/src/service.ts Show resolved Hide resolved
@Feiyang1 Feiyang1 merged commit 3b338db into master Nov 10, 2021
@Feiyang1 Feiyang1 deleted the fei-delete-app branch November 10, 2021 17:59
@google-oss-bot google-oss-bot mentioned this pull request Nov 10, 2021
@firebase firebase locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase app never terminates, even after deleteApp()
3 participants