remove @firebase/app and @firebase/app-types from peerDependencies #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
jsdt,
mikelehen and
schmidt-sebastian
as code owners
hiranya911
reviewed
Aug 13, 2019
hiranya911
approved these changes
Aug 14, 2019
|
@schmidt-sebastian WDYT |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to solve the unmet
peerDependencywarning when@firebase/databaseis used in Admin SDK. firebase/firebase-admin-node#614@firebase/appwas intentionally removed from Admin SDK's dependency to solve a version conflict issue when it's used together with JS SDK. #1916Though this PR is not the most correct way to solve the issue, it is quick and easy with little impact on user experience. The only user experience change is that user won't get unmet peer dependency warnings if
@firebase/databaseis installed without installing@firebase/app.It should be a rare case as we ask user to install
firebasepackage in all our guides, which automatically includes@firebase/app.The alternative solution is create a separate npm package for admin sdk consumption. It feels like an overkill and adds a lot of maintenance burden on us for little benefit.