feat(firestore): add the ability to enable debug logging #11019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,7 +141,7 @@ jobs: | |||
| run-bootstrap: false | |||
| melos-version: '3.0.1' | |||
| - name: 'Bootstrap package' | |||
| run: melos bootstrap --scope tests | |||
| run: melos bootstrap --scope tests && melos bootstrap --scope "cloud_firestore*" | |||
There was a problem hiding this comment.
any reason why this now fails on Firestore? I noticed this on my own PR 🤔
There was a problem hiding this comment.
I've refactored the CI to use the same thing on test and cloud_firestore, but forgot to bootstrap those with melos. It would fail because it uses the pub.dev version :/
russellwheatley
requested changes
May 22, 2023
| @@ -547,6 +549,14 @@ - (void)namedQueryGet:(id)arguments withMethodCallResult:(FLTFirebaseMethodCallR | |||
| }]; | |||
| } | |||
|
|
|||
| - (void)setLoggingEnabled:(id)arguments withMethodCallResult:(FLTFirebaseMethodCallResult *)result { | |||
| FIRFirestore *firestore = arguments[@"firestore"]; | |||
| try { | ||
| await channel | ||
| .invokeMethod<void>('Firestore#setLoggingEnabled', <String, dynamic>{ | ||
| 'firestore': this, |
russellwheatley
approved these changes
May 23, 2023
Salakar
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a static function to enable debug logging.
Related Issues
closes #10995
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?