Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): allow 30 conjunctive & disjunctive queries for "in" & "array-contains-any" via where() API #11265

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jul 12, 2023

Description

Circled back to this and it seems the response has changed. I've reinserted commented out tests, and allowed "in" & "array-contains-any" queries to have up to 30 filters.

Related Issues

closes #11085

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley merged commit f5477b1 into master Jul 12, 2023
@russellwheatley russellwheatley deleted the firestore-queries branch July 12, 2023 15:07
@firebase firebase locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] IN and array_contains_any should allow 30 values
3 participants