Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): add support for multiple database instances #11310

Merged
merged 28 commits into from
Aug 22, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jul 18, 2023

Description

Testing

  • Created a second database by the name of flutterfire-2. There is no emulator capability for second database so we're querying it live. This also proves it works as this collection is not allowed within security rules for the rest of the e2e test suite.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the blocked: do-not-merge PR blocked externally label Jul 18, 2023
@russellwheatley russellwheatley removed the blocked: do-not-merge PR blocked externally label Aug 8, 2023
@russellwheatley russellwheatley marked this pull request as ready for review August 8, 2023 14:35
@Salakar Salakar changed the title feat(firestore): create multiple database instances for the same Firebase project feat(firestore): add support for multiple database instances Aug 22, 2023
@russellwheatley russellwheatley merged commit ce6efcc into master Aug 22, 2023
24 checks passed
@russellwheatley russellwheatley deleted the firestore-choose-database branch August 22, 2023 13:12
@firebase firebase locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants