-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firestore, web): update setSettings
to allow usage of a up-to-date persistence on web
#12041
Conversation
setSettings
to allow usage of a up-to-date persistence on web
external PersistentSingleTabManager persistentSingleTabManager( | ||
PersistentSingleTabManagerSettings? settings, | ||
); | ||
|
||
@JS() | ||
external PersistentMultipleTabManager persistentMultipleTabManager( | ||
PersistentSingleTabManagerSettings? settings, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the aim to allow these in the future? (along with memoryEagerGarbageCollector()
& memoryLruGarbageCollector()
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we probably need to refactor the front facing API to expose those APIs. I have to draft the API Review
} else { | ||
cacheSizeBytes = settings.cacheSizeBytes; | ||
localCache = firestore_interop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After deprecation of enablePersistence
we no longer have an API to specify multiple tab behavior on Web. So, which tab manager will be used by default when I set persistenceEnabled: true
on Web?
Description
see title
Related Issues
fixes #12034
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?