Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): allow query with range and inequality filters on multiple fields #12564

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Apr 2, 2024

Description

See documentation for more information https://firebase.google.com/docs/firestore/query-data/multiple-range-fields

Related Issues

closes #12550

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Contributor

@TarekkMA TarekkMA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for tests to pass

@Lyokone Lyokone merged commit 00ae837 into master Apr 2, 2024
20 of 21 checks passed
@Lyokone Lyokone deleted the feat/allow-multiple-inequalities branch April 2, 2024 12:35
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…tiple fields (firebase#12564)

* feat(firestore): allow query with range and inequality filters on multiple fields

* remove more asserts

* format
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…tiple fields (firebase#12564)

* feat(firestore): allow query with range and inequality filters on multiple fields

* remove more asserts

* format
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…tiple fields (firebase#12564)

* feat(firestore): allow query with range and inequality filters on multiple fields

* remove more asserts

* format
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
…tiple fields (firebase#12564)

* feat(firestore): allow query with range and inequality filters on multiple fields

* remove more asserts

* format
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 16, 2024
…tiple fields (firebase#12564)

* feat(firestore): allow query with range and inequality filters on multiple fields

* remove more asserts

* format
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 16, 2024
…tiple fields (firebase#12564)

* feat(firestore): allow query with range and inequality filters on multiple fields

* remove more asserts

* format
@firebase firebase locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] Query with range and inequality filters on multiple fields
3 participants